Vscode-cmake-tools: Should use ${SystemRoot} ${ProgramFiles} ${SystemDrive} instead of "C:\\Windows" "C:\\Program Files" "C:".

[szzhiyang]

Not every Windows PC uses C as system drive letter. Please replace C:\\Windows C:\\Program Files C:\\Program Files (x86) C: to ${SystemRoot} ${ProgramFiles} ${ProgramFiles(x86)} ${SystemDrive}, thanks.

[szzhiyang]

Hi @bobbrow, the source files shown in the following screenshot hardcode C:\\ as Windows system drive, which may bring inconvenience to the users whose Windows system drive is not C:\\. They should use ${SystemRoot} ${ProgramFiles} ${ProgramFiles(x86)} ${SystemDrive} instead.

[bobbrow]

Yes, we should fix this.

[Zingam]

@bobbrow Would it be necessary to add these variables to the extension: ${SystemRoot} ${ProgramFiles} ${ProgramFiles(x86)} ${SystemDrive} or should I just use process.env to get the system paths as necessary?

[bobbrow]

Sorry that I was unclear on this one. I wasn't planning on adding new variables for this. I was agreeing that we should get them from the environment.

[Zingam]

@bobbrow I'll submit a PR to fix this issue later.

[Zingam]

@andreeis Didn't you merge the fix for this?

[bobbrow]

Yes, this was fixed. The replacement PR didn't link back to this issue. @andreeis can you make sure this was added to the CHANGELOG?

[andreeis]

Yes, it's mentioned:

• Use variables instead of hardcoded values for system path references. PR #1690

[bobbrow]

Cool. Looks like we can put the issue number in there instead of the PR now.

[andreeis]

Yes definitely, will do with my next PR.

[andreeis]

CMake Tools 1.7.0 was released today and it contains a fix for this issue. Upgrade the extension in VSCode and let us know if you encounter any other problems.