Vscode-bookmarks: bookmarks.toggle doesn't work in workspaces without a folder

[nachocab]

I'm getting bookmarks.toggle not found after the last vscode update. None of the other commands work either. I've tried re-installing the extension, but it doesn't work.

It's not a shortcut problem because I get the same when going through the menu command (although, instead of a yellow triangle with an exclamation, I get a red circle with an x)

[nachocab]

Ok. It appears like this was a workspace problem. I created a new workspace and the problem went away

[alefragnani]

Hi @nachocab ,

Good to know it's working now 👍

Is there a scenario that you could reproduce the error? I mean, an empty workspace/folder, an multi-root workspace, etc?

Thanks

[nachocab]

Thanks for the awesome extension!

I still think it's something related to the update because I didn't do anything weird to my workspace. If it happens again, I'll report back. 👍

[nachocab]

@alefragnani It happened again! This time I simply added a folder to the workspace (it didn't have any) and bookmarks.toggle started working again.

[alefragnani]

I still can't reproduce the error, no matter if it uses workspaces, folders or none of them. All scenarios appears to be safe and looking a bit closer, it appears the error is not related to empty workspaces/folders, but for large files, just like #31 .

If that's the case, there is no solution yet, because its caused by VS Code limitations.

[razvan-ciochina]

Hello,
I had a similar issue with files outside the workspace. In version 11.0.0 of the plugin there's a setting called: Bookmarks:Navigate Through All Files\Allow navigation look for bookmarks in all files in the project, instead of only the current.
This fixed any problem for me.
Hope this helps.

[alefragnani]

Hi @razvan-ciochina ,

These are two different scenarios. In your case, it’s not an issue, but the _default behavior_.

When the extension was created, the navigation only supported for the _current file_. So the Jump to Next And Jump to Previous didn’t look for other files in the project/workspace/session. After a few releases (in 2016 btw #8 ), I added this setting (default false) so the navigation will search for any file in your folder/workspace/session.

There is an open issue #102 to change the _default value_ of this setting to true (or even remove the setting and make it the only behavior).

Hope this helps.