Voyager: Can't update permissions when edit role

[d3turnes]

Version information

• Laravel: v5.7.*
• Voyager: v1.3.0 || v1.3.1
• PHP: 7.1.30
• Database: MySQL 8.0

Description

Can't update permissions when edit role, duplicate route
PUT|PATCH voyager.roles.update TCG\Voyager\Http\Controllers\VoyagerBaseController@update
PUT|PATCH voyager.roles.update TCG\Voyager\Http\Controllers\VoyagerRoleController@update

Steps To Reproduce

Steps to reproduce the behavior:

1. Edit role
2. Select permissions (p.e posts)
3. Send
4. Instead of executing VoyagerRoleController@update, VoyagerBaseController@update is executed

A possible solution

1. Edit Bread Role and add VoyagerRoleController as Main Controller

[MrCrayon]

Can you list exact versions installed not what you are requiring?
Voyager can be 1.3.0 or 1.3.1

Is this happening on a new install or it started after an update?

[d3turnes]

this happening on a new install
checked in both versions ( v1.3.0 and v1.3.1 )

[o2microsys]

i have the same problem in 1.3.1

[MrCrayon]

I was able to reproduce the bug, not really sure yet when this started.

Quick fix without changing any code set in roles BREAD configuration as Controller
TCG\Voyager\Http\Controllers\VoyagerRoleController

[MrCrayon]

@d3turnes v1.3.0 works fine.

The problem is the double declaration of the routes but the second one overrode the first one until #4605 (merged in 1.3.1) where parameter was changed causing two routes to coesist:

PUT|PATCH | admin/roles/{id}
PUT|PATCH | admin/roles/{role}

[MrCrayon]

Fixed with #4669

[admont28]

I was able to reproduce the bug, not really sure yet when this started.

Quick fix without changing any code set in roles BREAD configuration as Controller
TCG\Voyager\Http\Controllers\VoyagerRoleController

Same error in v1.3.1

I fixed it by editing the "Controller Name" of roles by _"TCG \ Voyager \ Http \ Controllers \ VoyagerRoleController"_

[panjitito]

Thank you, it works for me.

[bcmarcos03]

_TCG \ Voyager \ Http \ Controllers \ VoyagerRoleController"_

Thank you! This worked for me!

[kingIZZZY]

Voyager: v1.3.1
Issue still persists
This is NOT fixed yet, i.e. default vanilla installation of voyager still results in erroneous saving of users/roles

[MrCrayon]

@kingIZZZY This bug affects only v.1.3.1, it's fixed in 1.3-dev and next release (v1.3.2) will contain fix.
You can fix it in the way described in my other comment.

[kingIZZZY]

How can I composer update to the bleeding edge latest commits?
Even as time goes on and more commits happen it would be great if i can keep updating to the latest fixes

[Hirbod]

NOT fixed for me in 1.4-dev. I can't update the Roles page. Adding
TCG\Voyager\Http\Controllers\VoyagerRoleController als Controller name for BREAD "roles", and calling "php artisan optimize" worked for me.

[emptynick]

That's what's in the upgrade guide for 1.4, yes.

[MrCrayon]

@Hirbod that's because the final fix is setting that in BREAD but if you are updating you need to do that manually.
There was a temporary fix in 1.3.2 that didn't require to set that because it's a breaking change.

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. If you have further questions please ask in our Slack group.