Voyager: "article" route binding, brings strange voyager's behavior

[lawliet5130]

Version information

• Laravel: v5.4
• Voyager: v1.1
• PHP: v5.6
• Database: MariaDB 10.1

Description

After writeing this code in /routes/web.php

Route::bind('article',function($value){
    return \App\Article::find($value);
});

voyager won't allow me to edit/read any records from any bread, telling "This action is unauthorized."
Still i am able to add/browse. Edit/read buttons are also visible.

If you change "article" to, lets say "post" in route binding, all works fine.

Steps To Reproduce

Steps to reproduce the behavior:

1. Create a table named articles.
2. Create a bread for this table.
3. Add some records in your bread.
4. Go to /routes/web.php, add route binding for "articles".

Route::bind('article',function($value){
    return \App\Article::find($value);
});

1. Go to bread and press edit button on any record.
2. See error.

[fletch3555]

Could you, maybe, provide the error here...? Ideally a full stacktrace, not just a screenshot of the whoops page only showing the top 3 entries

[lawliet5130]

I cant find respective stacktrace in laravel.log(maybe its saved somewhere else, or I dont know).
So I just copyed it from browser.

(1/1) HttpExceptionThis action is unauthorized.

in Handler.php line 133
at Handler->prepareException(object(AuthorizationException))in Handler.php line 109
at Handler->render(object(Request), object(AuthorizationException))in Handler.php line 47
at Handler->render(object(Request), object(AuthorizationException))in Pipeline.php line 82
at Pipeline->handleException(object(Request), object(AuthorizationException))in Pipeline.php line 32
at Pipeline->Illuminate\Routing{closure}(object(Request))in VoyagerAdminMiddleware.php line 27
at VoyagerAdminMiddleware->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in SubstituteBindings.php line 41
at SubstituteBindings->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in VerifyCsrfToken.php line 65
at VerifyCsrfToken->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in ShareErrorsFromSession.php line 49
at ShareErrorsFromSession->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in StartSession.php line 64
at StartSession->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in AddQueuedCookiesToResponse.php line 37
at AddQueuedCookiesToResponse->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in EncryptCookies.php line 59
at EncryptCookies->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in Pipeline.php line 102
at Pipeline->then(object(Closure))in Router.php line 574
at Router->runRouteWithinStack(object(Route), object(Request))in Router.php line 533
at Router->dispatchToRoute(object(Request))in Router.php line 511
at Router->dispatch(object(Request))in Kernel.php line 176
at Kernel->Illuminate\Foundation\Http{closure}(object(Request))in Pipeline.php line 30
at Pipeline->Illuminate\Routing{closure}(object(Request))in TransformsRequest.php line 30
at TransformsRequest->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in TransformsRequest.php line 30
at TransformsRequest->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in ValidatePostSize.php line 27
at ValidatePostSize->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in CheckForMaintenanceMode.php line 46
at CheckForMaintenanceMode->handle(object(Request), object(Closure))in Pipeline.php line 148
at Pipeline->Illuminate\Pipeline{closure}(object(Request))in Pipeline.php line 53
at Pipeline->Illuminate\Routing{closure}(object(Request))in Pipeline.php line 102
at Pipeline->then(object(Closure))in Kernel.php line 151
at Kernel->sendRequestThroughRouter(object(Request))in Kernel.php line 116
at Kernel->handle(object(Request))in index.php line 54
at require_once('C:\xampp\htdocs\ionvinaga\public\index.php')in server.php line 21

And some additional info,later I created an bread for "categories" table, with model called Category.
So when I made bind for "category", like this:

Route::bind('category',function($value){
    return \App\Category::find($value);
});

I got this error when trying to edit/read category records.

[emptynick]

Can confirm that. Is that wanted by Laravel?
Solution is to bring the model-binding back:
$id = $id instanceof Model ? $id->{$id->getKeyName()} : $id;

[xwiz]

This will definitely fix the problem and is not a bad approach either.. People should be able to do model binding with any name if they so choose without conflict

[MrCrayon]

@lawliet5130 @fletch3555 I think this was partially fixed in https://github.com/the-control-group/voyager/commit/bc0489a5f3e6356d9cd4bcf998d271573e68452f but it still needs to be changed in show method.

Can you confirm?

[emptynick]

Closing due to inactivity.

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. If you have further questions please ask in our Slack group.