Voyager: New fields on exciting tables is now shown in BREAD editor

[Drivez]

• Laravel Version: 5.4
• Voyager Version: 0.11.10
• PHP Version: 7.1
• Database Driver & Version: Mysql

Description:

New fields added to the database after bread was created should appear in the bread editor.
Currently adding new fields to a table is not shown in the bread editor.

Steps To Reproduce:

install with dummy data, try adding a new field on an exciting table, the new field is not shown in the bread editor

[abdgad]

After you add new fields to a table, you will need to Edit BREAD for that table and hit save for the changes to take effect.

[fletch3555]

@abdgad, he was saying that they're not appearing in the BREAD editor at all. Would the save action create those entries?

[johnteee]

@abdgad In my case, after new fields are added, the new columns' indexes would not appear.
Same as @Drivez , I think it's a bug after order field added in 0.11.10.

The error message:

[johnteee]

Finally there's a workaround:
Delete the previous BREAD record first and set it again.
However it would cause risks to make wrong settings when we setup new BREAD informations.

In my point of view, new added columns such as added by migrations or by Voyager Admin, they should be checked if they didn't have any record in the BREAD.
Now the columns in BREAD editing pages seem to be generated according the BREAD records, however some of them might not be in the records.

[johnteee]

https://github.com/the-control-group/voyager/commit/5461692d0e51571c3e6df059e6e2eff461910e95

It seems to be fixed(not in 0.11.10 anyway :P)
It might be fixed in version 0.11.11

Currently I modified the codes of Voyager manually for workaround.

[abdgad]

Sorry for the misunderstanding.
@marktopper @fletch3555 we should tag a release.

[markoliverbrawn]

Any fix for this yet?

[nunomsh]

The "fix" is to delete the bread, and create it again... Not a fix, but at least you wont loose any data

[markoliverbrawn]

Are there any immediate plans to (really) fix this?

[fletch3555]

Did anyone confirm this was/wasn't fixed in 0.11.11?

If not, you should be able to just open and save the bread without making any changes (after adding the fields obviously). I agree it's still an issue that would need to be fixed though.

[markoliverbrawn]

Has 0.11.11 been released yet?

[fletch3555]

Apologies, I thought it had. Please test with the master branch. You can change composer to use "dev-master" as the version

[markoliverbrawn]

Looks good. Thanks.

[fletch3555]

Closing this as it's been confirmed fixed in master. If it hasn't made it to a release yet (unlikely), it will soon.

[laravelish]

@fletch3555 still the same problem in laravel 5.5.1 voyager dev-master

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. If you have further questions please ask in our Slack group.