Voyager: Issue with laravel 5.4

[lednhatkhanh]

• Laravel Version: 5.4
• Voyager Version: 0.11.8
• PHP Version: 7.1.1
• Database Driver & Version: Don't know

Description:

Hello, I noticed a few errors when using with laravel 5.4:

• [ ] I can't change the icons of what is displayed on the dashboard, it always show the voyager-group icon:

• [X] There is are no view published in the resources/views folder ()

• [x] The is no validation error message when I try to create a new post with the empty title, while I already set the rules like this: (There is already a PR here #1071 )

Steps To Reproduce:

• Create a new laravel 5.4 project by running this: laravel new sample
• Install voyager composer require tcg/voyager and install with dummy data

[davodavodavo3]

@lednhatkhanh yes there is a error with validation on posts

[davodavodavo3]

For validation on page of posts paste this in
\vendor\tcg\voyagerresources\views\posts\edit-add.blade.php

@if (count($errors) > 0)
                                <div class="alert alert-danger">
                                    <ul>
                                        @foreach ($errors->all() as $error)
                                            <li>{{ $error }}</li>
                                        @endforeach
                                    </ul>
                                </div>
                            @endif

Maybe programmers forget?)))))

[lednhatkhanh]

I think there should be a PR for this :)

[davodavodavo3]

Yes you are right friend. I open PR

[davodavodavo3]

for widgets there will be (must be) other structure.Now the icons and other options are hard coded in
\vendor\tcg\voyager\src\Widgets files.Config for them doesn't work((((

[lednhatkhanh]

Yeah, I saw that too, they must be forgot to load the config file...

[AdrianKuriata]

Hi, do someone problem like that?

http://i.imgur.com/satMZTv.png

When i try add validation for the field i getting error with undefined index, check pic.

[davodavodavo3]

@AdrianKuriata can you paste validation json?

[AdrianKuriata]

@davodavodavo3 I just copied for test validation JSON from docs

{
    "validation": {
        "rule": "required|max:12"
    }
}

[davodavodavo3]

maybe there is a solution for you
https://github.com/the-control-group/voyager/issues?utf8=%E2%9C%93&q=undefined%20index

[davodavodavo3]

name of you table order is in lowercase(order) or uppercase(Order)?

[AdrianKuriata]

@davodavodavo3 I tryied do validation for Categories from the Voyager categories table and i got this issue, probably this is bug and will be fix in the next soon update.

Default tables do not have a validations for this creations i hope Voyager will be hard developed because is awesome.

[davodavodavo3]

yes @AdrianKuriata you are right.
I found the PR https://github.com/the-control-group/voyager/pull/1041 where problem is resolved

[AdrianKuriata]

@davodavodavo3 Thanks for your help, i will try it on the weekend, i have a question to you. I never helped with projects on github. When i will do something for change, improve with voyager and update code, is possible they update it for the master branch?

[davodavodavo3]

Yes you are creating a new PR for updates and the project manager(programmers or company) can approve it or decline.You can also fork the project and make changes for you

[lednhatkhanh]

Hello, I think the settings to publish the view resource is very important, it should be fixed/added soon!

[fletch3555]

We made a conscious choice to no longer publish the views, and that's not going to change (and therefore isn't a bug). Published views are dangerous because they don't get updated if you update Voyager. If you're forced to manually copy the view file to override it, then that's a conscious choice that you make as a developer, and therefore it's on you to make sure it's updated.

[williamn]

@fletch3555 I agree. Perhaps you should update the documentation here as well as it is still states

By default a couple posts views have been published to your resources/views/vendor/voyager folder. So those 2 view files will be located at resources/views/vendor/voyager/posts/browse.blade.php and resources/views/vendor/voyager/posts/edit-add.blade.php.

[fletch3555]

Closing due to age. If this is still an issue after the 1.0 release, please open a new issue.

[gmfaruk]

"SQLSTATE[42S02]: Base table or view not found: 1146 Table 'db_voyeger.settings' doesn't exist (SQL: select * from settings) (View: C:\xampp\htdocs\5.5\vendor\tcg\voyagerresources\views\login.blade.php)

Please anyone hear?? to soloed my db problem??
please suggestion ,how do i do now??

[fletch3555]

@gmfaruk, please either open your own issue or post in our Slack group. Commenting on closed issues should be avoided.

[github-actions[bot]]

This issue has been automatically locked since there has not been any recent activity after it was closed. If you have further questions please ask in our Slack group.