Voyager: Multiple Images - Input Type => have no option to delete any image.

Created on 24 Feb 2017  Â·  8Comments  Â·  Source: the-control-group/voyager

  • Laravel Version: 5.4.*
  • Voyager Version: 0.11.2
  • PHP Version: 5.6.*
  • Database Driver & Version: MariaDB

Description:

Multiple Image data type is really nice. I love that, but there is no option to delete image

Steps To Reproduce:

Go to Database > BREAD > change Input Type to Multiple Images

bug

Most helpful comment

What would be the most neat/friendly way to remove image? I was thinking about using ajax and showing modal window to let user decide about further actions.

When you hover over image you get "toolbar" (at this moment only X to remove/delete image)
hover

And when you will click on X, you get modal
modal

  1. Should be image removed (stays in media folder) or deleted (completely removed from server)?
  2. What about option where both buttons are in modal. Remove and delete.

Feel free to comment and discuss.

CC: @marktopper

All 8 comments

@marktopper assign me to this one, please.

What would be the most neat/friendly way to remove image? I was thinking about using ajax and showing modal window to let user decide about further actions.

When you hover over image you get "toolbar" (at this moment only X to remove/delete image)
hover

And when you will click on X, you get modal
modal

  1. Should be image removed (stays in media folder) or deleted (completely removed from server)?
  2. What about option where both buttons are in modal. Remove and delete.

Feel free to comment and discuss.

CC: @marktopper

Sorry for the delay, have been some real busy days.

@sikhub: I think that is a great improvement! To answer your questions, then my believe are the followings:

  1. I think that the file should stay in media by default, since it's in my todo list to make it able to choose files for BREAD directly from the media library, therefor in future a file will be able to be used in multiple BREADs.
  2. It could however as you mention yourself be a good idea to let the user have a choice whether or not to delete it from the media library in a modal.

I am open for both solutions with or without this modal.

@marktopper No problem.

Cool. I will go with the first one then. We can still implement delete function in the future.

Awesome!

On 8. mar. 2017 18.10 +0100, Blaž Cigale notifications@github.com, wrote:
>

@marktopper (https://github.com/marktopper) No problem.

Cool. I will go with the first one then. We can still implement delete function in the future.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (https://github.com/the-control-group/voyager/issues/820#issuecomment-285103541), or mute the thread (https://github.com/notifications/unsubscribe-auth/ACIQ27ckOeDbn3KAT2HA0IYYx2goaNrfks5rjuEPgaJpZM4MKyRE).

Fixed in #890

Cheers,

This issue has been automatically locked since there has not been any recent activity after it was closed. If you have further questions please ask in our Slack group.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

raoasifraza1 picture raoasifraza1  Â·  3Comments

Nagendra1421 picture Nagendra1421  Â·  3Comments

kevinjon27 picture kevinjon27  Â·  3Comments

zzpwestlife picture zzpwestlife  Â·  3Comments

TXRRNT picture TXRRNT  Â·  3Comments