Vorta: Crash in 'diff' operation

Created on 20 Aug 2019 · 16Comments · Source: borgbase/vorta

Describe the bug
Displaying the results of a 'Diff' operation causes a crash.

To Reproduce
Steps to reproduce the behavior:

Go to 'Archives'
Click on 'Diff'
Select two random archives
Wait and observe crash

Desktop (please complete the following information):

OS: Fedora 30

Additional context
Traceback:

  File "/app/lib/python3.7/site-packages/vorta/views/archive_tab.py", line 456, in list_diff_result
    window = DiffResult(result['data'], archive_newer, archive_older)
  File "/app/lib/python3.7/site-packages/vorta/views/diff_result.py", line 80, in __init__
    files_with_attributes.append(parse_line(l))
  File "/app/lib/python3.7/site-packages/vorta/views/diff_result.py", line 60, in parse_line
    full_path = line[line.find(line_splitted[3]):]
IndexError: list index out of range

Flatpak info:

Vorta - Backup client

          ID: com.borgbase.Vorta
         Ref: app/com.borgbase.Vorta/x86_64/stable
        Arch: x86_64
      Branch: stable
     Version: v0.6.22
     License: GPL-3.0
      Origin: flathub
  Collection: org.flathub.Stable
Installation: system
   Installed: 69.5 MB
     Runtime: org.kde.Platform/x86_64/5.12
         Sdk: org.kde.Sdk/x86_64/5.12

      Commit: 747ccd36bac199696e666db72e9fb6cf9333e5eb89fd530bfba478e31ce1309b
      Parent: ab65debe01a91182501c5eb265859c1a3a6dc0f2437edcb50d7942c3f248dc78
     Subject: Update to v0.6.22 (7d9c4382)
        Date: 2019-08-04 22:24:11 +0000

Source

SuborbitalPigeon

All 16 comments

Happens to me too exactly the way described above, but only for my 'real' backup. For a small test-repository it does not seem to happen.
My system:
debian stretch with Python 3.7.0 compiled from source (so no flatpak is involved). Vorta installed via pip:
vorta --version
Vorta 0.6.22

$ vorta 
$ Traceback (most recent call last):
  File "/home/tycho/.local/lib/python3.7/site-packages/vorta/views/archive_tab.py", line 456, in list_diff_result
    window = DiffResult(result['data'], archive_newer, archive_older)
  File "/home/tycho/.local/lib/python3.7/site-packages/vorta/views/diff_result.py", line 80, in __init__
    files_with_attributes.append(parse_line(l))
  File "/home/tycho/.local/lib/python3.7/site-packages/vorta/views/diff_result.py", line 60, in parse_line
    full_path = line[line.find(line_splitted[3]):]
IndexError: list index out of range

tycho-kirchner on 21 Aug 2019

Crashed for me too. Not using it, but maybe we should disable it, if it's not ready?

m3nu on 21 Aug 2019

I personally like the feature, especially to see files I actually want to get rid off (;
Of course one could still use the cli, but maybe it's not so difficult to fix?

tycho-kirchner on 21 Aug 2019

I wanted to wait to respond until I have access to my PC again, but okay.

It is possible that I oversaw an edge case. @m3nu could you please send me the output of borg diff which failed with Vorta per mail (only if it doesn't contain sensible data). I assume that the bug is quite simple to fix.