Void-packages: Package Request: vscodium

[Itamiko]

Would love to have this package since this version will use the latest of vscode but with MIT license

also disables the telemetry build flag.

Github Link

[Cogitri]

Don't we already disable telemetry in our vscode @shizonic ?

[maxice8]

On Fri, Apr 05, 2019 at 12:20:25AM -0700, Rasmus Thomsen wrote:

Don't we already disable telemetry in our vscode @shizonic ?

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/void-linux/void-packages/issues/10582#issuecomment-480174356

iirc Void Linux doesn't touch default telemetry, only on Firefox i think.

[shizonic]

@Cogitri It was disabled earlier but I was asked to remove the patch.

[Cogitri]

Ah, alright.

[Cogitri]

IMHO maybe we should abandon VSCode all together then and only package VSCodium?

[maxice8]

IMHO maybe we should abandon VSCode all together then and knly package VSCodium?

Sounds good by me. Opinon @void-linux/pkg-committers ?

[shizonic]

Fine for me too. But we should be aware of adding the ms store url anyway to be able to download extensions.

[Cogitri]

Yup

[Hoshpak]

So from what I understand, this is just a custom build configuration which is then offered as a binary package? As much as I dislike all that electron stuff, can't we just adjust our vscode build configuration to our liking and keep building from source?

[shizonic]

Correct. This was exactly what I had before and was asked to remove... ;)

[maxice8]

@shizonic there is a vscode update available, please add vscodium configuration to it.

[TheOneWithTheBraid]

Anyone interested in merging?

[Duncaen]

Not really, merging binary packages is bad because they would lock our repos when we update a dependency with a shared library bump and we can't rebuild the binary package.

[TheOneWithTheBraid]

I see. If I would create a version to build from source?

[Duncaen]

This might be possible if we can get shared electron packages like arch linux has.
Building whole chromium just for this one package is a no go, because it adds a lot of maintenance burden in regard of patching and build time.

[shizonic]

If there is enough interest, I'll try to package electron.

[TheOneWithTheBraid]

Please do! I would kindly like to contribute.

[ProjectMoon]

A shared electron package would be useful for other things that need it (e.g. riot-desktop).

[shizonic]

A shared electron package would be useful for other things that need it (e.g. riot-desktop).

Feel free to package it.

[Cogitri]

FWIW I recently made a MR for it for Alpine. It does compile now, but SIGSEGVs on musl. Maybe it'll work on glibc for you though: https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/7310

[shizonic]

Thank you. I'll give it a shot asap.

[Johnnynator]

I just gave it a try and got vscode on both glibc and musl running. I will post a PR later after cleaning some things up.
@Cogitri Intresting that it didn't work on Alpine, the only patch I added for Void was for glibc and no other changes to patches.

https://i.imgur.com/emvLfe4.png

[Cogitri]

Nice! :)

Apparently it _does_ work on Alpine, but electron likes to crash on XWayland (so it only works on X11). Do you happen to use X11, @Johnnynator ?

[Johnnynator]

Yeah, I was running on X11.

[Johnnynator]

But works also fine with Plasma wayland

[Cogitri]

Huh, weird, it crashes for me like this with GNOME Wayland: https://github.com/electron/electron/issues/9662#issuecomment-62211440

Can you maybe give me your electron x86_64 musl package so I can test if that works on Alpine too?

[shizonic]

Vscode natively on musl ?! A dream becomes true ... !

[Johnnynator]

@Cogitri https://void.johnnynator.dev/electron/ has the binary , also I forgot to mention, I removed a system zlib patch for the time since it somehow broke the build system (would be suprised if that actually "fixed" anything)

[Cogitri]

Hm, seems like that SIGSEGVs for me too when I do /usr/lib/electron7/electron and starting VSCode only shows:

$ code-oss
Warning: 'app' is not in the list of known options, but still passed to Electron/Chromium.

:thinking:

[Cogitri]

Sorry to clutter the issue with that, but can you maybe give me a VSCode package too, @Johnnynator 😅

[shizonic]

Guess you are talking about a musl version? @Cogitri

[Cogitri]

Yup

[shizonic]

@Cogitri Have you seen this: https://github.com/Johnnynator/void-packages/commit/e51b6a1fe705d1986448bc6d735bfe00b09550d5

[Johnnynator]

@Cogitri https://void.johnnynator.dev/electron/ has now everything I have build so far (also a test repo for everyone who is intrested)

[shizonic]

@Johnnynator You are awesome! Thanks a lot. I would adapt it for my current vscode 1.45.0 PR if you like.

[Johnnynator]

@Johnnynator You are awesome! Thanks a lot. I would adapt it for my current vscode 1.45.0 PR if you like.

Feel free to do so.

[shizonic]

This includes electron itself ?