Vocabulary: Wonky padding in header on mobile/ tablet breakpoints
Describe the bug
After design sprint 1 (#723) was merged, the header now has some wonky padding in mobile breakpoints
- The Search logo is pushed too far to the right
- The hamburger is not pushed off of the right side of the screen
To Reproduce
- Go to ccsearch-dev.creativecommons.org
- Use browser to simulate a mobile/ tablet screen
- See error
Screenshots
Desktop (please complete the following information)
- OS: Win 10 Pro 1909
- Browser: Firefox Dev. Ed. 75.0
akmadian
All 17 comments
Would like to work on this
Tanuj22
on 20 Mar 2020
go ahead @Tanuj22
akmadian
on 20 Mar 2020
@akmadian The hamburger should be in the right corner?
Tanuj22
on 20 Mar 2020
yep, right corner of the header
akmadian
on 20 Mar 2020
@akmadian, since it's labeled as the good first issue. So As per the new code contribution guidelines of CC, I just submitted a PR.
abhisheknaiidu
on 21 Mar 2020
Sorry I got busy in some personal work. @abhisheknaiidu You could have just informed me and submitted a PR for it.
Tanuj22
on 21 Mar 2020
@Tanuj22 Oh sorry for that, actually I didn't see any assigned person, so I thought that no one is working on this, and so I submitted a PR.
abhisheknaiidu
on 21 Mar 2020
@abhisheknaiidu Yep, please be sure to read through issue threads to see if anyone else has said that they are working on it before starting work. We may not always assign the issue to someone properly, but it was already marked as in progress so that should have been a pretty good indicator :/
We are ok with people starting on an issue without recieving approval from a maintainer (work on the issue itself has to be approved, but for someone to actually do that work does not need approval). We ask that people indicate in the issue thread that they are working on the issue, and that if someone has indicated that they are working on it, that others do not start work on it.
akmadian
on 21 Mar 2020
Yea @akmadian so sorry, I won't repeat again!
abhisheknaiidu
on 21 Mar 2020
This needs to be fixed in Vocabulary, transferring the issue there. @Tanuj22 @abhisheknaiidu please submit a PR there.
kgodey
on 25 Mar 2020
I would like to work on this seeing that no one else has been, please. Thanks in advance.
oneshasappleton
on 11 Apr 2020
thank you
oneshasappleton
on 16 Apr 2020
@dhruvkb I think this issue has been fixed and can be closed.
Tanuj22
on 28 Apr 2020
@akmadian can you verify https://github.com/creativecommons/vocabulary/issues/241#issuecomment-620800448?
dhruvkb
on 1 May 2020
@dhruvkb @akmadian Is the issue still up for grabs? If yes, can I work on it?
Dishebh
on 26 May 2020
Unassigned because of inactivity. Still waiting for @akmadian to verify https://github.com/creativecommons/vocabulary/issues/241#issuecomment-620800448.
dhruvkb
on 28 May 2020
This is not an issue any more.
kgodey
on 12 Aug 2020
Related issues
zackkrida
路
3Comments
obulat
路
5Comments
zackkrida
路
5Comments
Dhruvi16
路
4Comments
zackkrida
路
5Comments
Most helpful comment
@abhisheknaiidu Yep, please be sure to read through issue threads to see if anyone else has said that they are working on it before starting work. We may not always assign the issue to someone properly, but it was already marked as
in progressso that should have been a pretty good indicator :/We are ok with people starting on an issue without recieving approval from a maintainer (work on the issue itself has to be approved, but for someone to actually do that work does not need approval). We ask that people indicate in the issue thread that they are working on the issue, and that if someone has indicated that they are working on it, that others do not start work on it.