Visx: TooltipWithBounds bug

[terpimost]

I think in TooltipWithBounds the line unstyled={unstyled} should be deleted because we checking styles in the style property

With that line if I use unstyled TooltipWithBounds no position will be set because inside ToolTip no styles will be set at all because they should be taken from TooltipWithBounds.

https://github.com/hshoff/vx/blob/8ede587c3cc47d56736bc58f99e3d8a94a1e0850/packages/vx-tooltip/src/tooltips/TooltipWithBounds.tsx#L53

[williaster]

@terpimost sorry for the delay, agree this is likely a bug! would happily review a PR 😁

[singhanurag05]

Hey @williaster may I remove the line? I'm new to open-source and I think I can do this!

[terpimost]

@singhanurag05 go ahead and remove the line

[singhanurag05]

Hi @terpimost can you please check PR #828 I did it.

[terpimost]

Its not up to me to check PRs in that repo, lets wait.

On October 1, 2020, Gary Kahn [e-mail] wrote:

Hi @terpimost https://github.com/terpimost can you please check PR

828 https://github.com/airbnb/visx/pull/828 I did it.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/airbnb/visx/issues/767#issuecomment-702187264, or

unsubscribe auth/AAOQVTJ5HYOUZSFPMBDTGB3SISJCVANCNFSM4PFG73HA>.