Virtual-environments: Add PHP 8.0

[shivammathur]

Tool information

• Tool name: PHP 8.0
• Tool license: PHP License 3.01
• Add or update? Add
• Desired version: PHP 8.0.0
• Approximate size:
• If this is an add request:
  
  
  
  • Brief description of tool: PHP is a popular general-purpose scripting language
  
  
  • URL for tool's homepage: https://www.php.net/
  
  
  • Provide a basic test case to validate the tool's functionality: php -v
  
  

Area for Triage: PHP

Question, Bug, or Feature?: Feature

Virtual environments affected

• [X] Ubuntu 16.04
• [X] Ubuntu 18.04
• [X] Ubuntu 20.04
• [X] macOS 10.15
• [X] macOS 11.0
• [X] Windows Server 2016 R2
• [X] Windows Server 2019

Can this tool be installed during the build?
Yes

Tool installation time in runtime
2 to 3 min depending on OS

Are you willing to submit a PR?
Yes.

• This request is mainly to add PHP 8.0 on Ubuntu runners.
• On Windows and macOS, in next update as per current scripts, PHP would update to 8.0 automatically and since starter workflows do not pin PHP version, many workflows might break.

A good solution would be to install PHP 8.0 keeping 7.4 default on all 3 OS, which you can change say after a month to make PHP 8 default.

[maxim-lobanov]

Hello @shivammathur ! Thank you for feature request.
Feel free to submit PR fo adding PHP 8.0 on Ubuntu.

As for the Windows and MacOS, thank you for raising concern. We will take a look deeper.

[shivammathur]

@maxim-lobanov I will create the PR for Ubuntu, should I switch to PHP 8.0 as default or keep 7.4 default for now.

[AlenaSviridenko]

Hi @shivammathur, thank you for the heads up, we have discussed possible risks internally and decided to go ahead with the latest PHP. This is how our macOS and Windows images always installed PHP (with Homebrew for macOS and Choco for Windows). If we would hardcode the previous version - we will receive requests to add the latest PHP, so the proper way would be to install 2 versions which will require significant refactoring of current logic.

The recommended way to use tools on images is through setup-* tasks, and setup-php in this case, so the workaround for any issues seems to be pretty easy.

Thanks.

[shivammathur]

@AlenaSviridenko Thanks for the clarification. Created PR #2162

[AlenaSviridenko]

@shivammathur , FYI: we found out that PHP 8.0 brings VS2019 build tools that caused issues on our Windows image previously. So we are hard-coding PHP 7.4 for some time https://github.com/actions/virtual-environments/pull/2170

[shivammathur]

@AlenaSviridenko Yes, Chocolatey has changed dependency from vcredist140 to visualstudio2019buildtools for PHP 8 unnecessarily.

[miketimofeev]

@shivammathur just a quick update — macOS and Ubuntu images with PHP 8 were deployed, for windows, we're still waiting for the chocolatey package to be fixed

[shivammathur]

@miketimofeev Thanks, I have verified the same🙂