Virtual-environments: Error because ANDROID_NDK_PATH / HOME contain spaces

Created on 18 Jun 2020  路  7Comments  路  Source: actions/virtual-environments

Describe the bug
ANDROID_NDK_PATH / HOME should not contain spaces. Otherwise, the script C:\Program Files (x86)\Android\android-sdk\ndk-bundle\ndk-build.cmd gives an error

 'C:\Program' is not recognized as an internal or external command,
operable program or batch file.

Here is the commit changing the previous working behaviour https://github.com/actions/virtual-environments/commit/c1ad396b6af869c12147a50d902fa8b252770f51

The workaround is running the C:\Program Files (x86)\Android\android-sdk\ndk-bundle\build\\ndk-build.cmd directly

Android C++ Windows bug

All 7 comments

Hello @AndrewPlakhotnyi,
Thank for your report. We will take a look at it.

@AndrewPlakhotnyi Hello,
Thank you for the issue reported.
We have reproduced the issue on our side and find several possible workarounds for it. You can track a current status in a pull request .
I will keep you informed.

Hey @Darleev if theres a mitigation for this that can be applied individually until the next update, that would be extremely helpful.

@compnerd In order to mitigate the issue, it is possible to return the old NDK path and use it in your pipeline. Steps below should help you with it:

Azure DevOps Powershell:

$androidNDK = (Get-ChildItem -Path "C:\Microsoft\AndroidNDK64\"| Sort-Object -Property Name -Descending | Select-Object -First 1).FullName
Write-Host "##vso[task.setvariable variable=ANDROID_NDK_HOME;]$androidNDK"
Write-Host "##vso[task.setvariable variable=ANDROID_NDK_PATH;]$androidNDK"

GitHub Actions Powershell:

$androidNDK = (Get-ChildItem -Path "C:\Microsoft\AndroidNDK64\"| Sort-Object -Property Name -Descending | Select-Object -First 1).FullName
echo '::set-env name=ANDROID_NDK_HOME::$androidNDK'
echo '::set-env name=ANDROID_NDK_PATH::$androidNDK'

Hello @AndrewPlakhotnyi ,
The PR has been merged. All changes will be available after the next image rollout.
I will keep you informed.

@AndrewPlakhotnyi I'm sorry, the PR still in review state. I will let you know additionally when it will be merged.

Since we didn't hear any other complaints about current ANDROID_NDK_HOME variable, I am going to close this issue.
Please, feel free to open a new one if anything else is needed from our side.

Was this page helpful?
0 / 5 - 0 ratings