Vimium: Missing Link Hints

[jmagaro88]

Starting this morning, I am noticing a large number of link hints missing when I browse pages I am familiar with.

For example, in this image below, notice how there are no link hints for the Smart Home Devices on the right side of the page.

Or on this page, there are not link hints for any of the CNN Business headlines on the right side of the page.

Strangely, it seems like the missing link hints are all on the far right side of the browser window.

[philc]

FYI @poacher2k (who developed #3486 and #2251) and @gdh1995 -- could one of you take a look? I couldn't reproduce the issue on cnn.com, but I can easily reproduce the Amazon.com case on master. Here's a screenshot. The unhinted link in this image carousel changes based on how wide the window is.

Here's the carousel on amazon with a wider window:

[matthew-cline]

Possibly related: go to this image board, press f, press Esc, then press f again. The image thumbnails on the rightmost column won't have any hints on the second and subsequent times f is pressed, though they did the first time.

I'm using Chrome 80.

[gdh1995]

Well, it seems that Vimium's HUD hides them.

[arobase-che]

I'm experimenting the same on zestedesavoir.com :s

It seems to happen only on link from the right up corner.

@matthew-cline: Ty, I can reproduce.

[gdh1995]

@philc , it's enough to just modify

https://github.com/philc/vimium/blob/5ccd6dc4f2dd081d96bdeb2e71bb4f0b9015b674/content_scripts/vimium.css#L328

into height: 58px.

[philc]

Doh! I’ll fix tonight and release to chrome store. Great find; kind of
hilarious.

On Sun, Feb 9, 2020 at 6:29 PM Dahan Gong [e-mail] wrote:

@philc https://github.com/philc , it's enough to just modify

https://github.com/philc/vimium/blob/5ccd6dc4f2dd081d96bdeb2e71bb4f0b9015b674/content_scripts/vimium.css#L328

into height: 58px.

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
https://github.com/philc/vimium/issues/3486?email_source=notifications&email_token=AAACDFUFIJHBKXUTVNNFB2DRCC3XHA5CNFSM4KSCNHS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELHBEHQ#issuecomment-583930398,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAACDFQLD5FF5C7FYM2S7OLRCC3XHANCNFSM4KSCNHSQ
.

[lornajane]

I'm using vimium-ff in firefox and I still see this exact issue - nothing in the right hand quarter of the screen gets labelled. It looks like it updated though - the add-on page says last updated 3 hours ago, and I removed and re-added my add-on. Still no joy. Is there anything I can do to help debug this?

[gdh1995]

The lastest version (v1.65.1) works well on my Firefox 72 and Win 10. Have you installed two Vimium from unpacked zip files?

Or try this: vimium_ff-1.65.1-fx.xpi.zip (downloaded from https://addons.mozilla.org/firefox/downloads/file/3502765/vimium_ff-1.65.1-fx.xpi?src=dp-btn-primary)

[lornajane]

I installed via the add-ons and have restarted my browser. It is showing 1.65.1 as its version (I'm running Ubuntu) and I'm still missing some links on the right hand side of the screen.

[gdh1995]

@lornajane Could you give URL of the page or a screen snapshot? Maybe it is because of another reason.

[lornajane]

I can do both! https://www.theguardian.com/uk and screenshot attached

[poacher2k]

@lornajane : thank you for both screenshot and URL!

Many of these links have aria-hidden="true", which I assume is the reason the link hints aren't appearing.

[gdh1995]

Oh this is just [aria-hidden]:

[magios]

issue still exists in firefox and vimium 1.65.1

[lornajane]

it's funny, because all the links have the aria-hidden property, and sometimes I get hints, sometimes I don't. Scrolling a little in one direction or another sometimes causes more hints to appear, but most of the links further to the right are without hints.