Vimium: Opening link clears search query

[EmperorEarth]

• Chrome Version: 71.0.3578.98 64-bit Stable
• Vimium Version: 1.64.2

[smblott-github]

I don't understand what this means.

[EmperorEarth]

/ is the keyboard shortcut to the search functionality I'm talking about

Opening any link, whether via a keyboard shortcut, vimium or otherwise, by mouse, in current, foreground, or background tab or window, clears the search query. It doesn't matter which link, how the link is activated, nor which tab I click the link, the search query is lost.

Previously, I could: /foo, then press n..., [Shift+Enter], n..., [Enter], etc, to open any links that contained the word foo in them. I could even n... on other tabs. Now, as soon as I open a link, no matter which, how, or where I open the link, the foo query is lost/cleared from Vimium's search.

[smblott-github]

By "clears the query" you mean that the HUD input containing the query disappears?

This is the intended behaviour. The idea is that if the HUD loses the focus, then the user is finished with it. It's the same with the vomnibar and the help page.

(I'm not sure we'd want to change that without a good reason.)

[EmperorEarth]

No. As in if I press n or N again, it will say No query to find.

This is a change in behavior.

[AeliusSaionji]

I too think this is a problem.

The last search query should be remembered- so I can simply press n across different pages to search for the same text.

Right now, the search query is too easily reset. Having to retype the same search over and over is frustrating, and I find myself just falling back on firefox's internal search, because that remembers what I typed.

@smblott-github

[AeliusSaionji]

I believe this is the same issue: https://github.com/philc/vimium/issues/3217

[smblott-github]

Yes. There's definitely something broken. I'll look into it.

[EmperorEarth]

@smblott-github I think this is fixed? Not sure which version.

I'd like a second opinion before I close.

@0xC0FFEE @AeliusSaionji

[gdh1995]

Maybe by #3222, which has been merged in v1.65 ? If you mean a query history item in FindMode can not be used in a new tab.

[AeliusSaionji]

Seems to work across tabs + refreshes now. 👍

[philc]

Cool; closing. Thanks!