Vim: bug: Exit MULTI CURSOR when accessing through NORMAL MODE

[ofrades]

Describe the bug
When I am at --NORMAL-- and go to --INSERT-- MULTI CURSOR, ESC does not get me out back to --NORMAL--.
Instead goes to --NORMAL--MULTI CURSOR and the only way I found to put me out of MULTI CURSOR is to go to --VISUAL BLOCK-- MULTI CURSOR and from there I can go to --INSERT--MULTI CURSOR and ESC works properly putting me back to --NORMAL--

[J-Fields]

Hmm, hitting escape should get you out of multicursor mode from normal mode

[ofrades]

It works fine if you go to multicursor from Visual Block, but if you go from Normal does not.

[ofrades]

[J-Fields]

Hmm, weird. What platform are you on, and could you post your settings?

[ofrades]

Sure:
VS Code version: Code - Insiders 1.47.0-insider (b16b467d3e03e1a1ae05b5836e4e5a5af504e86d, 2020-07-01T05:32:07.483Z)
OS version: Windows_NT x64 10.0.18363

[berknam]

When you are on "Insert Multicursor" mode, if you press escape you are supposed to go to "Normal Mutlicursor" mode and then if you press escape again you go to "Normal" mode.

This AFAIK is by design!

The reason it goes straight to Normal mode after you use VisualBlock is because when in visual block if you go into insert mode VSCodeVim makes use of the multicursors so that you can see your insertions being applied on all cursors, it is considered a fake multicursor that is used just to make the insertions and then go back to normal mode. That is what is happening to you. When you're going to insert mode after VisualBlock VSCodeVim is creating the multicursors (even though they already existed) and then since it now considers these to be fake multicursors used only for the visual block insertions it lets you go straight to Normal mode.
This for me could maybe be considered the bug here.

But the normal behavior is:

• Enter Normal Multicursor mode
• Go to Insert Multicursor mode and make your changes
• Press escape to go back to Normal Multicursor mode
• Press escape again to go back to Normal mode (no multicursor) (Is this second escape not working for you? If so, that then is a bug!)

[ofrades]

Yes the second escape is not working, like I said, I am unable to leave the multicursor if I do that. The only way is to go to visual block and from there to insert multicursor and from there to normal multicursor and only after that escape works.

[berknam]

How are you entering to multicursor mode? Can you gives more info so we can try to reproduce that, your settings and/or installed extensions? Because I can't reproduce that.

[ofrades]

In normal mode I run the editor.action.selectHighlights, after that I go to insert mode with multicursor.

    {
      "before": ["leader", "m"],
      "commands": ["editor.action.selectHighlights"]
    }

[J-Fields]

That works fine for me. My intuition is that VimState.isMultiCursor is getting out of sync with the number of cursors somehow. If that's the case, it should be fixed by my multicursor test harness branch - I've been meaning to get to back to that...

[ofrades]

Is fixed now, thanks!!