Vim: Cursor style does not change properly when cursor mode has been changed

[kogai]

Describe the bug

When I change the mode of the cursor from NORMAL to INSERT, styles of the cursor hasn't been changed.

To Reproduce

Can reproduce only on vscode-insiders(actually version is 1.39 or later)

1. Open the file and focus to some text.
2. Press an 'i' or 'a' key
3. See what styles to a cursor applied

Expected behavior

Change styles of the cursor when mode has been changed.

Screenshots

Environment (please complete the following information):

• Extension (VsCodeVim) version: 1.10.2
• VSCode version: 1.39
• OS: macOS Mojave 10.14.5

Additional context

I don't know whether it's worth, vscode seems will become to be able to configure cursorStyle via editor's configuration.

https://github.com/microsoft/vscode/compare/release/1.38...master#diff-5a3a90617837271d84de842ed332110a

[J-Fields]

Reproduced on 1.39 insiders

[admosity]

Mine updated today and I had to set this option manually to get it working again:

    "vim.cursorStylePerMode.insert": "line",

[tadams42]

I removed golbal VSCode editor setting "editor.cursorStyle": "block" from settings.json and now it works.

VSCode 1.40.2, VSCodeVim 1.12.2

[jrwrigh]

Also running into issue. Rolling back to 1.11.3 worked for me (going back to 1.11.x to avoid the issues with #4342 )

[macintacos]

I removed the "editor.cursorStyle": "block" from my settings.json, and while that did work from going between normal/insert mode, my visual/replace modes aren't following the cursor style that's being explicitly specified. I have them in my settings like so:

  "vim.cursorStylePerMode.insert": "line",
  "vim.cursorStylePerMode.normal": "block",
  "vim.cursorStylePerMode.replace": "block-outline",
  "vim.cursorStylePerMode.visual": "block-outline",
  "vim.cursorStylePerMode.visualblock": "block-outline",
  "vim.cursorStylePerMode.visualline": "block-outline",

Used to work fine prior to 1.12.2.

[cvaldev]

I think this was resolved with #4468.

[J-Fields]

Should be. Someone holler if this isn't fixed in the next version (1.13.0)

[jrwrigh]

Can confirm that this is fixed in v1.13.0