Vim: Default selector via shift+arrow does not become visual mode

Created on 20 Mar 2018  路  3Comments  路  Source: VSCodeVim/Vim

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Bug
What happened:
Shift+arrow to select text not become visual mode, butshift+ <mouse-left> become visual mode
What did you expect to happen:
Shift+arrow to select should become visual mode
How to reproduce it (as minimally and precisely as possible):

Environment:

  • Extension (VsCodeVim) version: 0.11.2
  • VSCode version: 1.21.1
  • OS version: Arch 4.15.9-1
help wanted kinbug

Most helpful comment

Shift-End/Home does also not enter visual mode.
Partial mouse selection does however enter visual mode.

What did you expect to happen:
All selection methods should enter visual-mode - or not - but not half the selection modes.

All 3 comments

It seems that there is no problem when I press key 'v' to become visual mode.

Shift-End/Home does also not enter visual mode.
Partial mouse selection does however enter visual mode.

What did you expect to happen:
All selection methods should enter visual-mode - or not - but not half the selection modes.

I modify src\mode\modeHandler.ts, change

if ( e.kind !== vscode.TextEditorSelectionChangeKind.Mouse ) {
...
} 

to

if (
      e.kind !== vscode.TextEditorSelectionChangeKind.Mouse &&
      e.kind !== vscode.TextEditorSelectionChangeKind.Keyboard
    ) {
...
}

Now it support shift+arrow/shift+home/shift+end to goto visual mode.

Was this page helpful?
0 / 5 - 0 ratings