Vim-prettier: Why do the defaults differ?

Created on 1 May 2018  Â·  4Comments  Â·  Source: prettier/vim-prettier

Do you want to request a feature or report a bug?

Neither - just ask a question

What is the current/expected behavior?

The Readme.md states the following:

Note: vim-prettier default settings differ from prettier intentionally.

However, there's no reasoning as to why. Is it just personal preference? If so, perhaps it's worth clarifying that in the Readme (happy to do this if you agree).

Additionally/alternatively, it might be good to have a g:prettier#use_prettier_defaults setting rather than having to override them manually.

Apologies if I've missed something here; I did try to check previous issues. Thanks so much for all your work on this, I love it!

What version of vim-prettier are you using - (output of :PrettierVersion) ?

0.2.6

What version of prettier are you using - (output of :PrettierCliVersion) ?

1.11.1

question

Most helpful comment

Just bumping this, it took me ages to figure out why the defaults were different. The main problem I had is that the eslint-plugin-prettier module would complain about things that were being fixed by vim-prettier.

I would much prefer for vim-prettier to use the prettier defaults by default. I have pulled in the release/1.x branch, and this seems to fix the issue.

All 4 comments

This will change in v1.0.0 — there is already some changes in this direction in the release/1.x branch.

@docwhat Are the settings listed in the README the comprehensive set that differs from default settings?

I believe so.

Sent with GitHawk

Just bumping this, it took me ages to figure out why the defaults were different. The main problem I had is that the eslint-plugin-prettier module would complain about things that were being fixed by vim-prettier.

I would much prefer for vim-prettier to use the prettier defaults by default. I have pulled in the release/1.x branch, and this seems to fix the issue.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

hitochan777 picture hitochan777  Â·  14Comments

christopherball picture christopherball  Â·  4Comments

Luobata picture Luobata  Â·  7Comments

tugorez picture tugorez  Â·  7Comments

jrock2004 picture jrock2004  Â·  5Comments