Video-hub-app: Add 'select all' when batch tagging

Created on 31 May 2020  ยท  7Comments  ยท  Source: whyboris/Video-Hub-App

User requested. Seems simple enough -- add a button in the _manual tags tray_ โœ…

good first issue

All 7 comments

Hi, can I work on this feature?

Thank you ๐Ÿค

I'm sometimes rather particular about the UI (user interface), so don't worry too much about making things look great / harmonious with the rest -- I can fix it up after your code merges in ๐Ÿ‘

Please feel free to reach out with any questions -- I'm happy to help ๐Ÿ™Œ

Only suggestion for an addition here is: make the same button become "deselect all" once it has selected all, and maybe have the button have the format of "deselect all ()" so we have a better understanding.

You can see an example of the poc I did for this here: https://github.com/whyboris/Video-Hub-App/pull/482

although I'm not leveled up enough with angular to know how to pass down/bubble up the selected count to the right scope, but that's a solvable problem.

Also, I have tweaked the css to make the buttons look reasonable BUT they should probably be put in their own dive and made inline-block. But tbd.

Currently the deselect all can be accomplished by toggling the batch mode off.
I'm unsure about cramming too many buttons into the menu, but maybe deselect all is a worthwhile addition ๐Ÿค” thank you!
I especially like the "number selected" indicator ๐Ÿ˜

Thank you for the PR! I'll try to get to it this weekend ๐Ÿ˜
No worries about CSS -- I'll get it to look harmonious with the rest of the app (according to my sometimes-picky preferences ๐Ÿ˜… )

Thank you @jamesd35 for the feature addition #446 ๐Ÿ™‡ ๐ŸŽ‰ ๐Ÿค ๐Ÿฆพ

Cheers ๐Ÿ‘‹

Was this page helpful?
0 / 5 - 0 ratings

Related issues

cal2195 picture cal2195  ยท  5Comments

whyboris picture whyboris  ยท  3Comments

cal2195 picture cal2195  ยท  4Comments

cal2195 picture cal2195  ยท  4Comments

whyboris picture whyboris  ยท  5Comments