Video-hub-app: [shortcuts] Command + H on Mac shortcut conflict

Created on 16 May 2020  ยท  7Comments  ยท  Source: whyboris/Video-Hub-App

Command + H is the Mac command to hide the app which some users may use.

In VHA the same command hides all the panels which doesn't make for a good UX (user experience).

I'm open to suggestions for the fix. The easiest is probably reassigning the VHA shortcut to something else.

good first issue

All 7 comments

How about Command + K for Kiosk mode since I think that might be the underlying intention. Like Chrome's Kiosk mode ?

I love the K for "Kiosk" โœ…

This is a 2-line change that is perfect as a good first issue.

If no one picks it up, I'll do it on the day I'm releasing the next version of the app (whenever that is; no sooner than a month from now probably) ๐Ÿค

Let's wait until #443 lands as it touches the shortcut code ๐Ÿ‘

๐Ÿ‘‹ hello @martincaron -- the huge #443 finally landed ๐Ÿ˜…

Let me know if you'd like to fix this issue ๐Ÿ˜

can also take that one, waiting for approval

Hey @orkomlosh -- thank you for your contributions ๐Ÿ˜

Please feel free to feed two birds with one scone ๐Ÿ˜‰ by adding changes for this in your already-open PR #494 -- or as a separate PR -- whichever is most convenient for you ๐Ÿค

Thank you @orkomlosh for the fix #494 ๐ŸŽ‰

Was this page helpful?
0 / 5 - 0 ratings

Related issues

whyboris picture whyboris  ยท  5Comments

whyboris picture whyboris  ยท  5Comments

whyboris picture whyboris  ยท  3Comments

cal2195 picture cal2195  ยท  6Comments

cal2195 picture cal2195  ยท  6Comments