Vgstation13: device analyser can scan "premade" subtypes

[Kammerjunk]

Description of issue

fabricators print out objects of types defined in the designs they're given and the device analyser creates new designs willy nilly. this means you can scan things that were added to make mapping and/or coding easier as long as they have a design, such as

• pre-filled bottles containing nanobots or peridax or
• filled power cells (which are actually a parent of the empty cells). if you scan an ultra cell like this, it will only cost iron, glass, and plastic. see "specific information for locating" for more
• probably other things that I can't think of right now

Difference between expected and actual behavior

things that are supposed to be a bother to get aren't
things that are supposed to cost mining materials don't

Steps to reproduce

• find a cool item like the nanobots vial traders can get
• scan it
• print it for only the cost of its parent design

Specific information for locating

see here for how the device analyser accepts literally any item with a techlist:
https://github.com/vgstation-coders/vgstation13/blob/d9e848094b6925abf2f76e05e25d483a69edf908/code/modules/research/mechanic/device_analyser.dm#L76
see here for how getScanDesign() literally just makes a new design if it can't find one
https://github.com/vgstation-coders/vgstation13/blob/973cf9be516c21234d139145aa8c509dc7513f1e/code/modules/research/designs.dm#L118

Length of time in which bug has been known to occur

probably since mechanic was added in 2013? 2015? something like that.

Server revision

c721a09eea4a1a7f18941636ea25280f7e2e47a0

[DrSnips]

I thought power cells were already discussed in the past. Being able to scan ones that start full and print them full is a feature.

[Kammerjunk]

a legacy feature, maybe. what I'm saying is that if you scan one that starts full, you don't actually pay its real cost because it doesn't have a design
hence a full ultra cell costing only iron, glass, and plastic and a bottle of something awful costing only 1000 glass and a little bit of plastic

[Kurfursten]

Maybe it's time to accept that the general fab was a mistake

[DrSnips]

Extended that to the entirety of mechanic we have a deal.

[GreatBigFailure]

Delete this we were all keeping quiet about it for a reason. DELETE