Vgstation13: Adminhelps with characters like "帽" or "谩猫铆贸霉" aren't displayed and cause a Runtime

Created on 21 May 2017  路  6Comments  路  Source: vgstation-coders/vgstation13

Description of issue:

If you put some characters like the title ones in an adminhelp it's gonna cause a runtime, it gonna reproduce the bwoink sound but it would never display the message on the chatbox

Steps to reproduce:

  • Press F1
  • Type: "帽"
  • Enter

Issue bingo

  • [x] Issue could be reproduced at least once
  • [x] Issue could be reproduced by different players
  • [x] Issue could be reproduced in multiple rounds
  • [x] Issue happened in a recent (less than 7 days ago) round
  • [x] [Couldn't find an existing issue about this](https://github.com/d3athrow/vgstation13/issues)
Bug / Fix Goonchat

Most helpful comment

Good I don't wanna talk to foreigners

All 6 comments

Can't be fixed until we move the msay panel to goonchat.

john madden

Could we at least scan through incoming ahelps and just remove such characters before passing them to the msay panel's code?

@Shadowmech88 I mean I guess you could yeah but that's still hideous.

If anybody's interested in doing that, just wrap the text sent to the msay panel in strict_ascii(text) to remove non 7-bit ASCII values.

Good I don't wanna talk to foreigners

Was this page helpful?
0 / 5 - 0 ratings

Related issues

dylanstrategie picture dylanstrategie  路  3Comments

D3athrow-Issues picture D3athrow-Issues  路  3Comments

N3X15 picture N3X15  路  3Comments

D3athrow-Issues picture D3athrow-Issues  路  3Comments

DamianX picture DamianX  路  3Comments