Vgstation13: Camera Bugs tell people that they were hit with them when planted

Created on 24 Jul 2016  路  9Comments  路  Source: vgstation-coders/vgstation13

Description of issue

I used the camera bugs after messing around with buying random stuff and wanted to plant it on random people. Turns out they arent silently placed anymore and show others that they were hit with the camera bug when planted, making one of its main uses almost useless.

Difference between expected and actual behavior

Expected: It would silently slap the camera on the person, like it did before and like it does on normal objects
Actual Behavior: Made me drop spaghetti by showing an attack log in the chat, and that I have 'silently' planted it on the person. A cargo tech saw me and called me out.
screenshot_76

Steps to reproduce

Use the camera bug after setting the camera ID and put it on yourself/someone

Server revision

6b1d689a970962b2dd5e5e8f6e63cb4cdacfff45 Current Infomational Settings:
Protect Authority Roles From Tratior: 1

Issue bingo

  • [x] Issue could be reproduced at least once
  • [x] Issue could be reproduced by different players
  • [x] Issue could be reproduced in multiple rounds
  • [x] Issue happened in a recent (less than 7 days ago) round
  • [x] [Couldn't find an existing issue about this](https://github.com/d3athrow/vgstation13/issues)
Bug / Fix

Most helpful comment

Nah man you're in the clean. It clearly says you did it stealthily.

All 9 comments

Nah man you're in the clean. It clearly says you did it stealthily.

Either a missing return, or needs NOBLUDGEON

return
@9600bauds The latter?
_edit_: BUT WAIT
dreammaker_2016-07-25_19-49-22

Uhhhhhh
try making that return 0?

nope, return 0 does nothing @9600bauds

I think I know how to fix this. I managed to do it on another item I was working on that was based on camera bugs. I can open a pull request later today or tomorrow after testing it properly but all I did was this:

/obj/item/device/camera_bug/attack(mob/M as mob, mob/user as mob, def_zone)
  return

It should work, but I'd rather test first before opening the PR.

That would be a bad solution, we should really be looking at why NOBLUDGEON isn't working for suppressing messages.

NOBLUDGEON only suppresses messages that happen when you hit structures with the item - not mobs or anything else

Then it should be extended to mobs, probably.

Was this page helpful?
0 / 5 - 0 ratings