Vetur: missing not required props

[kibilizard]

• [x] I have searched through existing issues
• [x] I have read through docs
• [x] I have read FAQ

Info

• Platform: Win
• Vetur version: 0.27.1
• VS Code version: 1.48.2

Problem

in linting missed props whitch does not set as required

Reproducible Case

https://github.com/kibilizard/missing_non_required

[yoyo930021]

In #2141 ,
When no required or default, it have a warning about not have props.
So it's a feature not a bug.

[kaangokdemir]

Even it might be a good feature for new projects, is there a way to close this one especially for legacy projects? Also it's not working with v-model binding for value props.

Screenshots:

[kibilizard]

In #2141 ,
When no required or default, it have a warning about not have props.
So it's a feature not a bug.

you offer me to rewrite all projects because it your new feature?

[yoyo930021]

Even it might be a good feature for new projects, is there a way to close this one especially for legacy projects? Also it's not working with v-model binding for value props.

Screenshots:

I add a issue about this.

2236

[yoyo930021]

In #2141 ,
When no required or default, it have a warning about not have props.
So it's a feature not a bug.

you offer me to rewrite all projects because it your new feature?

It don't effect in runtime, so you can ignore it.
This feature is a reminder.
Maybe we can add a option to disable prop validator warning.
@octref

[victorgarciaesgi]

In #2141 ,
When no required or default, it have a warning about not have props.
So it's a feature not a bug.

Why does it needs to display a warning when all the props are optional?

[ilyakamens]

This is a great tool, and I've really enjoyed using it for the last several months.

I also see yellow squiggly underlines for non-required properties. I personally find it very distracting. IMHO, I'm not sure a warning is necessary for omitting an optional parameter, which I think is a standard use case. For example, Python linters don't complain when omitting **kwargs to function calls. It'd be great if there was a way to opt out of these warnings!

[octref]

@ilyakamens #2249

[Killea]

The logic is wrong.

[dipasqualew]

Can reproduce on VS Code on Ubuntu 20.04, in a Vue-Cli + TypeScript project.

The implementation fails the common use case of binding value with v-model. This breaks the linter. Please provide a way to disable the rule or account for situations where props are provided via directives.

Thanks

[adlio]

Here by way of Google help future searchers. When using v-model attributes, they all report:

<MyComponent> misses props: value

So if you're googling for why you're seeing "misses props: value" messages... this issue explains why.

[tobidalhof]

0.27.0 and 0.27.1 are broken? rolled back to 0.26.1 and the error was gone

[kmilogp8496]

Hi.
I've found this feature very useful, but I think you should fix this little issues with v-model and no required props. It would be nice to have type validation in template too. Thanks.

[Panbehkar]

I have this issue too -_-

[rockmandash]

@yoyo930021 Are optional props need to explicitly defined required: false in props section?

I just want to know what is the standard way to write Vue components.

[octref]

https://github.com/vuejs/vetur/releases/tag/v0.27.2

• v-model and sync issue is fixed in #2241.
• With #2249 you can turn prop validation off with "vetur.validation.templateProps": false

[dipasqualew]

Thank you @octref for your quick reaction on this 🙂

[yoyo930021]

@yoyo930021 Are optional props need to explicitly defined required: false in props section?

I just want to know what is the standard way to write Vue components.

I'd expect at least required or default for a serious pursuit.

props: {
  foo: {
    type: String
  }
}

But I think this case might be taken as required: false.
I will talk to @octref.

[yoyo930021]

In #2141 ,
When no required or default, it have a warning about not have props.
So it's a feature not a bug.

Why does it needs to display a warning when all the props are optional?

First of all, I didn't design this feature or at least not at first.
I found it in #2135 and handle some case in #2141

I think this feature is a reminder,
That's why we replace the error with a warning when it's not strictly defined.
I think VSCode's warning was too obvious and #2238 .
That's what's causing all the trouble.
But I think it's still a useful feature for strict projects.

[tomitrescak]

Sorry to write here, but I am not getting the error for required props. My prop is required, yet no warning or error is shown on the component that does not specify it.

[yoyo930021]

Sorry to write here, but I am not getting the error for required props. My prop is required, yet no warning or error is shown on the component that does not specify it.

Please set { "vetur.validation.templateProps": true }

[tomitrescak]

Thanks for the super fast answer. Got it!

[meatnordrink]

It's unfortunate that this is all-or-none. It would be great to have a warning when a required prop is missing; it's a hindrance to have an optional prop not passed throw a warning.

The most logical and helpful behavior would be:

• Error when a required prop is missing;
• No error when an optional prop isn't (because, as the property is optional, that isn't an error).

The solution above, turning off { "vetur.validation.templateProps": true }, means you have to choose between faulty validation or no validation.

(I realize Vetur is in an awkward position, as it's a volunteer project that's become fairly critical to the Vue community. .)

[IcedNet]

The logic is incorrect, if the prop is not required, not even if you are being "strict".
There is no need for any information at all.
I enjoy this tool, and several forks implement this properly - perhaps adopt one of their fixes?