Vetur: MIT License and Stylint dependency

[jabby]

• [x] I have searched through existing issues
• [x] I have read through docs
• [x] I have read FAQ

Info

• Platform: all
• vue-language-server : all versions which include stylint

First of all, I need to give you some context. I worked on Eclipse Wild Web Developer and I tried to include some vuejs support in it. See the current PR about my work.
During the process, I created a Contribution Questionnary (CQ) at Eclipse Foundation. The goal was to validate the needed dependencies on all legal aspect (IP process). IP validation failed because one of transitive dependencies is under GPL-3.0 License. My contribution is actually blocked but it's not the point of this issue.

I reviewed the answer from the legal team. It seems that stylint is under GPL-3.0 License. In your case, stylint dependency comes from stylus-supremacy. I already create an issue about the license of stylint here : https://github.com/ThisIsManta/stylus-supremacy/issues/58

I'm not an expert about OSS licenses, maybe there is no problem. I'm only concern about the compliance between vue-language-server license and stylint license. I know my case is not the same as yours. My work is under Eclipse Public License 2.0.

Thanks a lot for your answer and some clarification about licenses.

[octref]

Thanks for letting me know. The repo's LICENSE.md seems to be GPLv2, not v3.

I don't think there's anything actionable from me. From what I see in Stylus-supremacy codebase, it's using source files of stylint, so it should have been GPL. But I'm using Stylus-supremacy as a dependency through its public API, while making no modifications to it. So I'm not obliged to make VLS GPL.

One change I could do is to remove Stylus-supremacy from VLS dependency and only load it from workspace. This means no out-of-the-box formatting for Stylus part, but that's ok IMO.

[jabby]

Hello @octref sorry for the delay.

From my point of view, removing the out-of-the-box formatting of Stylus part will enable the integration of vls into Eclipse Wild Web Developer. If you are ok with this change, I will continue my work about supporting vue into Eclipse IDE.

[jabby]

Hello @octref do you want a PR about removal of Stylus-supremacy from VLS dependency. If so, can you show me where to start?

[davydnorris]

Hi @jabby @octref

I was just wondering if there had been any further progress on this, so that Vuejs support can be added to Wild Web Developer?

Many thanks!

[zulus]

ThisIsManta/stylus-supremacy#58 has been fixed. What's next?

[davydnorris]

@octref - looks like the Stylus GPL issue is now resolved. Does that mean you can simply upgrade to resolve your side of this, or is there more?

[octref]

looks like the Stylus GPL issue is now resolved.

It wasn't. Stylint 2.0.0 is still GPL licensed.

[jabby]

@octref What about your proposal?

One change I could do is to remove Stylus-supremacy from VLS dependency and only load it from workspace. This means no out-of-the-box formatting for Stylus part, but that's ok IMO.

Can I help you on this? If so, can you point me where to start? Thanks.

[davydnorris]

I've added this to stylint as a new issue:
/SimenB/stylint/issues/459

[sbernard31]

@octref, @jabby do you still consider this solution ?

One change I could do is to remove Stylus-supremacy from VLS dependency and only load it from workspace. This means no out-of-the-box formatting for Stylus part, but that's ok IMO.

[sbernard31]

By the way styleInt sounds no so active : https://github.com/SimenB/stylint/commits/master :thinking:
And it seems difficult to get feedback from maintainer : /SimenB/stylint/issues/459

[yoyo930021]

Ha, Does anyone care about this?

One change I could do is to remove Stylus-supremacy from VLS dependency and only load it from workspace. This means no out-of-the-box formatting for Stylus part, but that's ok IMO.

I think this is acceptable.
I would like to merge PR or help remove it.

[davydnorris]

I would love this to finally be added - would be happy to remove Stylus

[dkechrologos]

me too

On Tue, Mar 23, 2021 at 12:08 AM davydnorris @.*>
wrote:

I would love this to finally be added - would be happy to remove Stylus

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/vuejs/vetur/issues/1458#issuecomment-804427801, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/ANCCNZ23Y3X4WJ6XKAAQIHTTE65VRANCNFSM4I72SPMQ
.

[yoyo930021]

I will do it when finishing other issues.

If anyone can help, the PR is welcome.

To change here:
https://github.com/vuejs/vetur/blob/master/server/src/services/dependencyService.ts

[davydnorris]

I'm happy to have a crack at this - is it just a matter of pulling all references to Stylus from this file, or do we then have to do some magic to define it as an externally supplied dependency?

[yoyo930021]

I'm happy to have a crack at this - is it just a matter of pulling all references to Stylus from this file, or do we then have to do some magic to define it as an externally supplied dependency?

I think just removing the bundled stylus-supremacy package.
Remove this line https://github.com/vuejs/vetur/blob/8c99eec0815ce4cf7f8f5a58cbffa0f126e5e939/server/src/services/dependencyService.ts#L14 and make error or logic when no any package in project https://github.com/vuejs/vetur/blob/8c99eec0815ce4cf7f8f5a58cbffa0f126e5e939/server/src/services/dependencyService.ts#L228.

Other place only has typescript type information in vetur.