Vetur: Formatting of JavaScript in .vue files is broken after release of Prettier 1.13.0

[zavarka]

Info

• Platform: macOS
• Vetur version: 0.12.3
• VS Code version: 1.23

Problem

Formatting of JavaScript in the <script> block is broken with the release of Prettier 1.13.0. Format Document does not make any corrections.

In contrast, the <style> block is being formatted as expected.

Installing Prettier 1.12.1 in the project and reloading VSCode fixes the issue:

npm install -D -E [email protected]

Reproducible Case

1. Create a VueJs project by running vue init webpack-simple and accepting the defaults.
2. Open App.vue and introduce a misalignment or a trailing space inside the <script> block.
3. Run "Format Document".
4. Observe that no corrections are made in the <script> block.
5. Install Prettier 1.12.1 using the npm command given above and reload the window.
6. Run "Format Document".
7. Observe that the formatting issues added in step 2 are corrected.

[lesonky]

I have the same problem,so I changed the setting

"vetur.format.defaultFormatter.js": "vscode-typescript"

it works well.

[patrickcate]

I'm having the same issue. The following error is shown in the vue language server output log:

prettier-eslint [ERROR]:
Prettier-Eslint format failed
[Error - 12:17:56] No parser could be inferred for file: **the path to the local file**

Changing the default formatter to typescript like @lesonky suggested didn't fix.

[octref]

@zavarka @lesonky @patrickcate I cannot reproduce it though. I'm on prettier 1.13.4 and it works fine for me. Can you still repro on 1.13.4 or is it only 1.13.0?

[octref]

Seems this is a prettier issue: https://github.com/prettier/prettier/commit/1350edc5a65bded15b9dfc27d5e2a0706d9d1fe1

It has been addressed since 1.13.1.

[zavarka]

@octref Thanks for taking a look! I'm still able to reproduce the problem with [email protected], and downgrading to [email protected] still fixes it.

I don't have prettier installed globally. Only in the specific project.

[octref]

@zavarka For this project https://github.com/octref/veturpack

If you clone it and run yarn add -D [email protected]. This still happens to you?

[zavarka]

@octref Yes, the same issue occurs with the project https://github.com/octref/veturpack. Initially, the formatting works, but after running yarn add -D [email protected] it no longer works.

[patrickcate]

@octref I upgraded the Prettier VSCode extension, which now uses [email protected], and I'm still running into the same error as well.

[HADB]

I have the same problem!

I will get the following error when formatting if I set prettier.eslintIntegration to true.

Prettier-Eslint format failed
[Error - 16:24:40] No parser could be inferred for file: ...

VSCode version: 1.24.1
Vetur version: 0.12.5
Prettier plugin version: 1.5.0

I had to set prettier.eslintIntegration to false to make formatting work.

[Airkro]

@octref Maybe you should reopen this issues.

Since v1.13.x, Pettier make a breaking change. And prettier/prettier@1350edc didn't fix it, just trigger a warning.

When I install Pettier 1.13.x, VLS output No parser could be inferred for file.

[octref]

@Airkro We bundle prettier 1.11.1. How are you updating?

[Airkro]

@octref Sorry, I mean install it in my project root, just yarn add -D prettier

[octref]

@Airkro Thanks, will track it in #835.