Vesta: Typo in v-add-letsencrypt-user

Created on 4 Aug 2017  Â·  13Comments  Â·  Source: serghey-rodin/vesta

Operating System (OS/VERSION):

All

VestaCP Version:

0.9.8

Issue:

Typo discovered - https://github.com/serghey-rodin/vesta/blob/master/bin/v-add-letsencrypt-user#L58

"perm" should be "pem"

bug confirmed

Most helpful comment

How to reproduce on DO:

If I install Vesta on totally clean server — everything works fine.

But if I add PHP7.1 repo and update&upgrade system before install, I get this error:
Error: LetsEncrypt account registration 400

  1. Create Droplet Ubuntu 16.04.3 x32
  2. ssh root@IP
    3.
add-apt-repository ppa:ondrej/php
apt-get update
apt-get upgrade -y
apt-get dist-upgrade
curl -O http://vestacp.com/pub/vst-install.sh
sudo groupdel admin 
bash vst-install.sh
  1. Change DNS A record for used domain
  2. Open Vesta CP and try to receive LE certificate => error
  3. After fixing file /usr/local/vesta/bin/v-add-letsencrypt-user =>everything works

All 13 comments

+1

Confirm a bug in 0.9.8 v17 on Ubuntu 16.04.03 LTS

+1

confirmed issue with "Ubuntu 14.04.5 LTS" too.
root@webapps01:~# v-add-letsencrypt-domain user domain.com
pkey: Invalid format "perm" for -inform
pkey: Use -help for summary.
Error: LetsEncrypt account registration 400

tried correcting the typo, but getting below error after that.

sed: can't read /usr/local/vesta/data/queue/letsencrypt.pipe: No such file or directory

manually create the file by doing: touch /usr/local/vesta/data/queue/letsencrypt.pipe
VestaCP has issue creating this file, sometime.

@narookak
DO
Ubuntu 14.04 x64
v-add-letsencrypt-domain user domain.com

I cant reproduce this problem. The certificate is added successfully

@anton-reutov, thanks, I will give it a try again.

@narookak, try and let me know if problem still exits

This is working now, after applying fix suggested by @noogen

i think that missing pipe is because the installer, i think i didn't see it in the debian installer when the stucked development and forking topics came up

How to reproduce on DO:

If I install Vesta on totally clean server — everything works fine.

But if I add PHP7.1 repo and update&upgrade system before install, I get this error:
Error: LetsEncrypt account registration 400

  1. Create Droplet Ubuntu 16.04.3 x32
  2. ssh root@IP
    3.
add-apt-repository ppa:ondrej/php
apt-get update
apt-get upgrade -y
apt-get dist-upgrade
curl -O http://vestacp.com/pub/vst-install.sh
sudo groupdel admin 
bash vst-install.sh
  1. Change DNS A record for used domain
  2. Open Vesta CP and try to receive LE certificate => error
  3. After fixing file /usr/local/vesta/bin/v-add-letsencrypt-user =>everything works

Do we really need to re-create? This is reported as a typo: https://github.com/serghey-rodin/vesta/blob/master/bin/v-add-letsencrypt-user#L58

exponent=$(openssl pkey -inform perm -in "$key" -noout -text_pub |\

It is specified here, valid values are: DER or PEM

https://wiki.openssl.org/index.php/Manual:Pkey(1)

-inform DER|PEM
This specifies the input format DER or PEM.

In this case, the typo is perm with the extra r instead of pem

Fix accepted.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

SteenSchutt picture SteenSchutt  Â·  7Comments

progcode picture progcode  Â·  3Comments

developer-av picture developer-av  Â·  7Comments

albasyir picture albasyir  Â·  7Comments

DaniWinter picture DaniWinter  Â·  5Comments