Venus: Use Go modules

Created on 8 Mar 2019  路  10Comments  路  Source: filecoin-project/venus

Description

So long gx 馃憢 we are migrating dependency management to go modules

Acceptance criteria

Given the above resources, figure out how to move from gx to go-mod and do this.

Risks + pitfalls

Where to begin

A close reading of the above resources, or talk to @Kubuxu. Seems like @anacrolix and @raulk are also good people to consult on this.

E-good-first-issue

Most helpful comment

I think I can do this

All 10 comments

A really useful Step 0: investigate all the resources pointed out above, and then draft a plan.

I think I can do this

See comments in #2221 about all the trouble I found..

A quick bit of context: we really want a good plan for this, but would like to land the actual, possibly-disruptive changes after our next release (so from 1 April).

agree with @anorth lets not land this this week

I will continue at fil-fridays pace. I don't think there is a way to have a "good plan" without actually trying to do it like I did and surface the issues. Other than that, the actual go-modding is a very simple process. All the issues steam from the tooling around go-filecoin but there are no issues with go-filecoin itself.

I don't think there is a way to have a "good plan" without actually trying to do it like I did and surface the issues

@hsanjuan This makes sense. Continuing at fil-fridays pace sounds good 馃檶

I believe @anorth's comment on "good plan" was to clarify that this doesn't need to be completed for the upcoming release next week 鈥斅爊ot "plan only, don't try it in code". Is that right @anorth?

@hsanjuan you got scooped by @Stebalien: https://github.com/filecoin-project/go-filecoin/pull/2307

If there is more work to be done it should be added as a commit on 2307.

Should this be closed? It's not yet fixed.

oh, sorry, I somehow thought #2307 had been merged

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mishmosh picture mishmosh  路  6Comments

shannonwells picture shannonwells  路  5Comments

rosalinekarr picture rosalinekarr  路  7Comments

ognots picture ognots  路  7Comments

phritz picture phritz  路  7Comments