Venus: ensure all cli and plumbing units are fil

Created on 13 Feb 2019  路  5Comments  路  Source: filecoin-project/venus

https://filecoinproject.slack.com/archives/CEHHJNJS3/p1550048966147300

  1. PART 1: there MIGHT be some mismatch between units in the cli that is leading to this problem. all cli units should be FIL, not attofil. that we store in attofil internally is an implementation detail.

please ensure there is nothing about attofil in the wiki and somehwere in the wiki it says that cli units are always fil.

  1. PART 2: ensure that people can create messages with reasonable price/limit paramters. eg limit 1000 and price 1. they need to have filecoin from the faucet to send. you can see any failures only on a mining machine, you can use kibana to search for cid. @acruikshank is the source of truth for gas settings.

please do not merge anything w/o discussion as we are in a code freeze today

C-bug

All 5 comments

ensure that people can create messages with reasonable price/limit paramters. eg limit 1000 and price 1

We can change this, but currently the faucet is rate limited on wallet address to one request every 24 hours. The faucet currently gives out 1000 FIL.

We can change this. However, we should take into account the value our users can work with and make sure the faucet can supply realistic amounts of FIL to allow for workflows we expect them to execute in a 24 hour period.

We should probably pick a price value to use in the wiki that will not use up all the funds of our users quickly

_As a side note, the devnet miners are set to a price of 10-9 FIL / byte / block. This means that it costs 2.88FIL to store a 1MB file for 24 hours (1061MB · 10-9FIL/byte/block) · (24h · 60m · 60s / 30blk time)_

I'd suggest going with a reference gas price of 0.005, which will mean a message which costs 100 GAS will cost 0.5FIL. I don't believe anything runs above 300 GAS, which caps everything at 1.5FIL.

We can go lower, but 0.005 seems like a small enough value, while also not being too hard to type out.

FYI nothing about attofil in the wiki and there is a note about all units being in FIL in the "commands" section: https://github.com/filecoin-project/go-filecoin/wiki/Commands

I have also updated the mining tutorial with a troubleshooting note.
https://github.com/filecoin-project/go-filecoin/wiki/Mining-Filecoin#start-mining

As far as I know moving forward with price=0 limit=1000 as suggested by @anorth is canonical and good. The wiki is consistent with this and no attofile in sight. Is this ok to close out?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

jscode017 picture jscode017  路  9Comments

jscode017 picture jscode017  路  6Comments

mishmosh picture mishmosh  路  6Comments

phritz picture phritz  路  5Comments

mishmosh picture mishmosh  路  9Comments