Venus: Tell bad people who return bad errors from actors how to do better

Created on 8 Jan 2019  路  6Comments  路  Source: filecoin-project/venus

Description

We get it, we're bad people. We've seen the error message. We've made actors return errors that are not RevertErrors or FaultErrors. We're sorry.

In order to grow however we need to know where these errors are coming from. Let's change this panic to inform us right away which method and error from that method are incorrect. Let's become better.

Acceptance criteria

Actor, method, and error responsible for the panic displayed in the error message.

Risks + pitfalls

Where to begin

Should be a quick fix. The link again is:
https://github.com/filecoin-project/go-filecoin/blob/master/actor/export.go#L100

All 6 comments

Sounds helpful.

BTW you added it to candidates column but per https://github.com/filecoin-project/pm/blob/master/go-filecoin/dev-process.md#big-picture forgot to add it to the weekly candidates issue, which this week is https://github.com/filecoin-project/go-filecoin/issues/1560. I added it there for you. (Lemme know if we think the issue is a little too much process. We added it to make it easier for people to review candidates ahead of time.)

@lanzafame feel free to submit a PR with the work you've done. No pressure tho if you don't have time.

@ZenGround0 What is the process for me as I don't have access to create a PR/branch in this repo? Do I fork it or can I get access?

@lanzafame is this in progress? if so please assign it to yourself. (and thank you)

@mishmosh can you give @lanzafame write access to this repo so he can create a PR for this?

@lanzafame: you should have access now. Ping me if it didn't go through.

Was this page helpful?
0 / 5 - 0 ratings