Vendure: Ability to return multiples prices in ShippingCalculator response
I have a plugin using ShippingCalculator that returns multiple prices from a carrier. Would be nice to get all prices in one request and return these values in ShippingCalculator. Today the ShippingCalculator must return a object with the price and metadata, maybe transform this response to an array could solve the problem.
jonyw4
All 6 comments
Can you clarify to me why a given carrier would have more than one price?
michaelbromley
on 6 Jul 2020
Ok. I have an example. Here in Brazil, I use a service called Melhor Envio its really similar to GoShippo, it's multi-carrier shipping software for e-commerce. If I make a request in this software with the package box dimensions and postal code, they return to me a response with all carriers and options with price and delivery time.
So, If I need to integrate this solution in Vendure it's easy, but I can only return just one value per shipping method. If the provider has 3 carriers to simulate shipping, I need to create 3 shipping methods in vendure, which its fine to me... But to return all values I will need to make 3 requests to the same provider.
jonyw4
on 6 Jul 2020
OK thanks for the explanation. I'll leave this open and let's see if in future others also have this requirement.
For now, you'll have to do it as 3 separate shipping methods as you said. You could perhaps get around the 3 API calls issue by creating a service which calls Melhor Envio and caches the request for a short period of time, so each ShippingMethod shares the same API call & response.
michaelbromley
on 6 Jul 2020
This is a really good workaround @michaelbromley! How I can cache this values in Vendure? Do you have some ideia?
jonyw4
on 6 Jul 2020
I would create a service, e.g. CarrierService (name it whatever makes most sense of course) and then expose a getShippingCosts(order) method.
The first time it gets called, it makes the API call and then stores the resulting Promise in a JavaScript Map object, with the order id as the key. Subsequent calls to the getShippingCosts method with the same order id would just return that stored promise rather than making a new API call.
Once the API call resolves, all 3 callers of the getShippingCosts method will have the data they need. You'll have to implement some mechanism to then clear the cache or maybe also store the time that the API call was made, and if it was longer than e.g. 5 seconds ago, then make a fresh call.
michaelbromley
on 6 Jul 2020
I love the ideia. I will try to implement that in my MelhorEnvio ShippingCalculator
jonyw4
on 6 Jul 2020
Related issues
stefanvanherwijnen
路
5Comments
Zyles
路
8Comments
rrubio
路
5Comments
option-greek
路
3Comments
chladog
路
7Comments
Most helpful comment
I would create a service, e.g.
CarrierService(name it whatever makes most sense of course) and then expose agetShippingCosts(order)method.The first time it gets called, it makes the API call and then stores the resulting Promise in a JavaScript
Mapobject, with the order id as the key. Subsequent calls to thegetShippingCostsmethod with the same order id would just return that stored promise rather than making a new API call.Once the API call resolves, all 3 callers of the
getShippingCostsmethod will have the data they need. You'll have to implement some mechanism to then clear the cache or maybe also store the time that the API call was made, and if it was longer than e.g. 5 seconds ago, then make a fresh call.