Velero: add an env named `ALIBABA_CLOUD_CREDENTIALS_FILE`

Created on 18 Dec 2019  路  2Comments  路  Source: vmware-tanzu/velero

Can I work to add an env named ALIBABA_CLOUD_CREDENTIALS_FILE in pkg/install/deployment.go and pkg/install/daemonset.go which will be used by velero-plugin-for-alibabacloud ?

ArePlugins

Most helpful comment

Hi @haoshuwei

A few things:

1) Yes, for now I think a PR adding that env var would be fine. Please note that as part of #1910, we're going to look at ways for plugins to inform Velero of the credentials they need, so this is unlikely to be a permanent solution. However, I don't know when the new approach will be ready, likely not until v1.4 at the earliest.
1) Please also make a PR for this to the chart
1) Could you add the velero-plugin topic to your GitHub repo? This will help users find your plugin in the list more easily.

All 2 comments

Hi @haoshuwei

A few things:

1) Yes, for now I think a PR adding that env var would be fine. Please note that as part of #1910, we're going to look at ways for plugins to inform Velero of the credentials they need, so this is unlikely to be a permanent solution. However, I don't know when the new approach will be ready, likely not until v1.4 at the earliest.
1) Please also make a PR for this to the chart
1) Could you add the velero-plugin topic to your GitHub repo? This will help users find your plugin in the list more easily.

cc @carlisia

Was this page helpful?
0 / 5 - 0 ratings

Related issues

carlisia picture carlisia  路  4Comments

doronmak picture doronmak  路  3Comments

Marki4711 picture Marki4711  路  3Comments

Berndinox picture Berndinox  路  3Comments

onedr0p picture onedr0p  路  3Comments