Velero: Support wildcards for --include-resources and --exclude-resources

[sands6]

[sands6]

ark backup create test --include-resources *.acme.com

This wildcard support for resources is not supported right now and would be helpful to open a feature request in regards to this.

[ncdc]

Thanks @sands6 for the feature request! I'll add a bit more detail on how it could be implemented

[ncdc]

To do this, we'd probably need to create a new struct that's a bit broader than just collections.IncludesExcludes. Probably something like this:

type ResourceMatcher struct {
  groupWildcards sets.String
  resources *collections.IncludesExcludes
}

And then in the constructor, it would evaluate the user input and split wildcards from regular resources as needed.

[rosskukulinski]

If we're going to support wildcards, should we go so far as to support proper Regex?

[ncdc]

I think basic * wildcard matching will be a lot easier for users to use

[nrb]

To clarify a bit further, are you thinking of a single wildcard (*) and not wild card completion? (mynames*)?

EDIT: Ah, I see, it would be wild card completion based on the earlier comments.

[ncdc]

Right, *.acme.com, foo*bar, foo*bar*baz.acme.com, etc.

[kivagant-ba]

This also can be useful to ignore *.ark.heptio.com to do backup/restore between clusters.