Vector: Add `podLabels` template variable to DaemonSet template for Helm

Created on 26 Aug 2020  路  4Comments  路  Source: timberio/vector

Current Vector Version

0.11.0-nightly-2020-08-18 via Helm

Use-cases

The current Helm template for the Vector DaemonSet does not appear to let a user installing Vector into a kubernetes cluster via Helm to modify pod labels. It does, however, already allow a user to modify pod annotations. For any number of reasons, users may like to label all nodes belonging to a given DaemonSet.

Attempted Solutions

Our current workaround is to patch the DaemonSet created by Helm immediately after it is created. This works, but is clunky

Proposal

Add a new podLabels section to the Vector Helm DaemonSet template, in the same way that you already have for pod annotations. This will allow users to add pod labels via a values.yaml file passed to Helm.

setup kubernetes enhancement

Most helpful comment

Excellent. I'll put together a (presumably small) PR tomorrow. Thank you.

All 4 comments

I'd be happy to work up a PR, if that would facilitate this feature, unless there is some reason that this feature has been intentionally left out. Otherwise, I suspect it would be a fairly minor change. Let me know what is easiest...

It is something I missed while working on the feature initially, feel free to create a PR, I'd be happy to review :smile: No reason not to have this.

Excellent. I'll put together a (presumably small) PR tomorrow. Thank you.

@MOZGIII: PR submitted. It is very small.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

raghu999 picture raghu999  路  3Comments

LucioFranco picture LucioFranco  路  3Comments

jamtur01 picture jamtur01  路  3Comments

binarylogic picture binarylogic  路  4Comments

LucioFranco picture LucioFranco  路  3Comments