0.11.0-nightly-2020-08-18 via Helm
The current Helm template for the Vector DaemonSet does not appear to let a user installing Vector into a kubernetes cluster via Helm to modify pod labels. It does, however, already allow a user to modify pod annotations. For any number of reasons, users may like to label all nodes belonging to a given DaemonSet.
Our current workaround is to patch the DaemonSet created by Helm immediately after it is created. This works, but is clunky
Add a new podLabels section to the Vector Helm DaemonSet template, in the same way that you already have for pod annotations. This will allow users to add pod labels via a values.yaml file passed to Helm.
I'd be happy to work up a PR, if that would facilitate this feature, unless there is some reason that this feature has been intentionally left out. Otherwise, I suspect it would be a fairly minor change. Let me know what is easiest...
It is something I missed while working on the feature initially, feel free to create a PR, I'd be happy to review :smile: No reason not to have this.
Excellent. I'll put together a (presumably small) PR tomorrow. Thank you.
@MOZGIII: PR submitted. It is very small.
Most helpful comment
Excellent. I'll put together a (presumably small) PR tomorrow. Thank you.