Vcpkg: Having a problem with vckpg: installing the Azure IoT SDK for C

[SatishBoddu-MSFT]

Describe the bug
I am following the MS docs quickstart on creating an IoT Plug and Play device for Windows i.e Quickstart: Use a device capability model to create an IoT Plug and Play Preview device (Windows) and I'm having issues preparing the development environment.

When I get to installing the SDK with vcpkg (step 2 in preparing the dev environment section) running this command gives me an error:

.\vcpkg.exe install azure-iot-sdk-c[public-preview,use_prov_client]

Environment

• OS: [e.g. Windows 10]
• Compiler: revision

To Reproduce
Steps to reproduce the behavior:

1. .\vcpkg.exe install azure-iot-sdk-c[public-preview,use_prov_client]
2. Error: :1:47: invalid character in feature name (must be lowercase, digits, '-')
   on expression: azure-iot-sdk-c[public-preview,use_prov_client]
   ^
   Example:
   vcpkg install zlib zlib:x64-windows curl boost

Repro code when trying the Step2 on quickstart

Expected behavior
Install Azure IoT C device SDK Vcpkg: should be succesful.

Failure logs
-Error: :1:47: invalid character in feature name (must be lowercase, digits, '-')
on expression: azure-iot-sdk-c[public-preview,use_prov_client]

Additional context
Similar issue reported on Stackoverflow as well.

[SatishBoddu-MSFT]

Hello @ericmitt , Could you please help us in this matter.

[NancyLi1013]

Hi @SatishBoddu-MSFT
Thanks for posting this issue.
It seems that the feature name contains some invalid characters. You can update use_prov_client as use-prov-client in both CONTROL file and portfile.cmake. Then try to rebuild this.

[SatishBoddu-MSFT]

@NancyLi1013 Worked like a PRO!!!! Thanks a lot.
@ericmitt , How should we proceed further with the documentation?, do we have to include this workaround or will there be any changes from SDK side or VCPKG side ?

Go to the Folder : C:\Users\satish\vcpkg\portsazure-iot-sdk-c
1) Edit the CONTROL file in any file editor, update _use_prov_client_ as use-prov-client

2) Edit the portfile.cmake file : update _use_prov_client_ as use-prov-client

3) run
.\bootstrap-vcpkg.bat

4) run
.\vcpkg.exe install azure-iot-sdk-c[public-preview,use-prov-client]

[NancyLi1013]

@SatishBoddu-MSFT
I have submitted a PR to fix this.
Could you please help if it can work for you?

[SatishBoddu-MSFT]

@SatishBoddu-MSFT
I have submitted a PR to fix this.
Could you please help if it can work for you?

@NancyLi1013 I did a fresh pull from github, used the updated command , it is Now Working!!!

.\vcpkg.exe install azure-iot-sdk-c[public-preview,use-prov-client]

I have to update the documentation to reflect the updated command, below is the command which needs to be updated.

Thanks again !

[NancyLi1013]

Yes, the feature name should be the same as that in CONTROL file. Thanks for your update.