Vcpkg: [tensorflow-cc] build failure

[trade-commander1]

Host Environment
Windows 10 64 bit (1903) VM (VMWareWorkstation)

To Reproduce
.\vcpkg.exe install tensorflow-cc:x86-windows-static tensorflow-cc:x64-windows-static
Failure logs
Build fails. From log:
ERROR: C:/projekte/dev_apps/vcpkg/buildtrees/.bzl/_bazel_general/yvqyet6t/external/snappy/BUILD.bazel:7:1: C++ compilation of rule '@snappy//:snappy' failed (Exit 2): cl.exe failed: error executing command
logs.zip

[JackBoosY]

C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\yvals_core.h(298): fatal error C1189: #error: STL1001: Unexpected compiler version, expected MSVC 19.15 or newer.

What's version of your Visual Studio?

I can reproduce the build failure but the error is different:

1. The ::tensorflow::internal::LogMessage in logging.h :: could not be recognized.
2. Generated x64 but expect x86.

And, tensorflow does not support 32 bit system. See documentation.

[trade-commander1]

Hello, Visual Studio Version is 15.9.15, currently latest.
Just tried to build 64 bit only

.\vcpkg.exe install tensorflow-cc:x64-windows-static

and this failed as well.

[JackBoosY]

@trade-commander1 Yes, so I'm fixing static build now.
As a temporary solution, you only need to build tensorflow again.

[trade-commander1]

@JackBoosY
Made a fresh run (so deleted buildtree ..cc, download,etc.). Still fails.
Logs attached. Thank you for help.
log.zip

[JackBoosY]

The error I encountered was in the macro LOG ::tensorflow is not recognized.
Error in your logs:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\yvals_core.h(298): fatal error C1189: #error: STL1001: Unexpected compiler version, expected MSVC 19.15 or newer.

So I guess Visual Studio 2017 or newer is required to build tensorflow.

[trade-commander1]

Thank you for picking this for me. I use latest VS 17 update. It seems you need VS 19.
Only the god of programmers knows what happens when migrate to VS 19.
Will all the other vcpkg libraries build with VS 19?

[trade-commander1]

Hello,
with VS 2019 installed, build was successfull. Thank you.

[trade-commander1]

Perhaps a comment for build issues i had: It seems to hang at "configure..." Then type y press Enter to proceed. Also, do not forget to run
vcpkg integrate install
before build

[JackBoosY]

@trade-commander1 Thanks, I will check it with Visual Studio 2019. And I opened an issue in the github page of tensorflow-cc.

[JackBoosY]

Failure on Visual Studio 2019 16.2.1.

[Voskrese]

for myself
I have made, understated version for errors

edit "C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\VC\Tools\MSVC\14.16.27023\include\yvals_core.h" str 297

to #if _MSC_VER < 1900 // Coarse-grained, not inspecting _MSC_FULL_VER

))

[JackBoosY]

@Voskrese I think this is not a Windows SDK bug, it is a source code error. So your solution is temporary.

[Voskrese]

So your solution is temporary.

that's right, temporary )

[jgehw]

FYI: I had a more recent reincarnation of this problem:

C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.26.28801\include\yvals_core.h(298): fatal error C1189: #error: STL1001: Unexpected compiler version, expected MSVC 19.25 or newer.

Examining the log files, I found out that the most recent include files were used, but an older compiler (14.16.27023, although 14.26.28801 was also available).

I worked around this issue by uninstalling pre-2019 toolchains (MSVC v140 and v141).