Vcpkg: Update librealsense to v2.19

Created on 20 Mar 2019  路  6Comments  路  Source: microsoft/vcpkg

Can someone update librealsense to v2.19? There's a major pain point that has been resolved in the latest release. https://github.com/IntelRealSense/librealsense/issues/3065 @UnaNancyOwen @claudiofantacci

port-update

Most helpful comment

Hey! I can work on it from tomorrow :-)

All 6 comments

There's an open PR #5275 to update to v2.18 but it has met with some roadblocks.
Right now, we don't have the bandwidth to address the issue, so any help provided would be greatly appreciated.

Hey! I can work on it from tomorrow :-)

I'm wokring on this right now, but, as I'm not working with OpenNI, I will only be able to update and test the update.

The current version of the portfile has several errors under Windows.
The most important one concerns the installation of the debug build into the installation folder.
I'm investigating this and it seems an error introduced while fixing the portfile for Linux.

Also, I'm trying to configure the portfile to use ninja but there is a problem while fetching libusb from internet with git. I'm investigating whether the problem is in the librealsense CMakeLists or if it is a CMake issue in the ExternalProject_Add command.

Anyway, I hope to have a working updated portfile as soon as possible, with or without upstream fixes.

I'm finally able to compile configure and compile the library using ninja.

There is a permission/privileges conflict between processes when using ninja with -DBUILD_WITH_TM2=ON triggered by the custom target created with EcternalProject_Add.
I'll open a PR upstream to have feedback.

If you leave it to -DBUILD_WITH_TM2=ON (as default configuration), ninja build now complete succesfully. The -DBUILD_WITH_TM2=OFF was necessary due to the following error https://github.com/IntelRealSense/librealsense/issues/3483 that however I fixed with a patch that I'm trying to discuss upstream.

I'm trying the new portfile locally and then I'll update the PR.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

F0I0l0I0P picture F0I0l0I0P  路  3Comments

tzbo picture tzbo  路  3Comments

LilyWangL picture LilyWangL  路  3Comments

cjvaijo picture cjvaijo  路  3Comments

pakdel picture pakdel  路  3Comments