Valkyrie: [Bug] Lost Legends class names (Spanish)

[vidimus]

Describe the bug

On the character's class selection, class names from the expansion "Lost Legends" are not displayed. Instead of that, only quotation marks appear.
On the expansion selection screen, "Lost Legends" expansion name is not displayed either.

Expected behaviour

Names displayed.

Screenshots

Valkyrie Version

2.4.09

Desktop

• OS: Windows 10
• Browser: Chrome
• Version 83.0.4103.116 (Build oficial) (64 bits)

[Quantumrunner]

This problem occurs for every language except english because the translations are missing in the Road to Legend app.

Looks like the fallback to english is missing here for some reason.

[vidimus]

I see. Thanks for replaying. Is there any way to repair it? I've got this expansion on Spanish, so I could provide the Spanish terms to update it.

[Quantumrunner]

I don't think there is currently a workaround for this. You could manually add the translations to the spanish translation file but this will be overwritten when Valkyrie has to re-import the Road to Legend data:

@NPBruce Or is there a way to replace the Road to Legend translation with translations from Valkyrie?

[vidimus]

Is there anything I can do, @mayjak ? I mean about translating or giving class names in Spanish (zero idea about programming).

[mayjak]

@vidimus Sorry I missed your comment. Sure it would help if you provided the translations for Lost Legends. I would have some real data to test with :)

At the very least the english language fallback should work properly (coming soon along with general #1135 text handling improvements).

[vidimus]

Great, I will do it in a couple of days.

El martes, 29 de diciembre de 2020, Jakub Majewski [e-mail]
escribió:

@vidimus https://github.com/vidimus Sorry I missed your comment. Sure
it would help if you provided the translations for Lost Legends. I would
have some real data to test with :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/NPBruce/valkyrie/issues/1334#issuecomment-752024409,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJ45LBGVGT5TV7GB3V6NJY3SXGUKTANCNFSM4O6KSITA
.

[vidimus]

Here's the text (on a spreadsheet), @mayjak
I hope it helps you. If you need it in a different format, just tell me.

Lost Legends - Leyendas Perdidas.xlsx

| English | Spanish
-- | -- | --
CLASS_ELEMENTALIST_NAME | Elementalist | Elementalista
CLASS_ELEMENTALIST_1 | Earth and Sky | Cielo y tierra
CLASS_ELEMENTALIST_2 | Sun and Sea | Sol y mar
CLASS_ELEMENTALIST_3 | Primal Harmony | Armonía primordial
CLASS_ELEMENTALIST_4 | Storm's Fury | Furia de la tormenta
CLASS_ELEMENTALIST_5 | Volcanic Might | Poder volcánico
CLASS_ELEMENTALIST_6 | Spiritual Balance | Equilibrio espiritual
CLASS_ELEMENTALIST_7 | Nature's Embrace | Abrazo de la naturaleza
CLASS_ELEMENTALIST_8 | Nature's Fury | Furia de la naturaleza
  |   |  
CLASS_SOUL_COLLECTOR_NAME | Soul Reaper | Segador de Almas
CLASS_SOUL_COLLECTOR_1 | Spirit Link | Vínculo espiritual
CLASS_SOUL_COLLECTOR_2 | Unholy Bond | Enlace impío
CLASS_SOUL_COLLECTOR_3 | Blight Extraction | Eliminación de impurezas
CLASS_SOUL_COLLECTOR_4 | Cursed Soul | Alma maldita
CLASS_SOUL_COLLECTOR_5 | Ethereal Armor | Armadura etérea
CLASS_SOUL_COLLECTOR_6 | Galvanize | Galvanizar
CLASS_SOUL_COLLECTOR_7 | Reaper's Pact | Pacto del Segador
CLASS_SOUL_COLLECTOR_8 | Font of Vitality | Fuente de la vitalidad
  |   |  
CLASS_CRUSADER_NAME | Crusader | Cruzado
CLASS_CRUSADER_1 | Zealous Aura | Aura de fervor
CLASS_CRUSADER_2 | Righteous | Recto
CLASS_CRUSADER_3 | Divine Light | Luz divina
  |   |  
CLASS_HERETIC_NAME | Heretic | Hereje
CLASS_HERETIC_1 | Arcane Healing | Curación arcana
CLASS_HERETIC_2 | Dark Recovery | Recuperación oscura
CLASS_HERETIC_3 | Forbidden Arts | Artes prohibidas
  |   |  
CLASS_RAVAGER_NAME | Ravager | Devastador
CLASS_RAVAGER_1 | Momentum | Ímpetu
CLASS_RAVAGER_2 | Charging Assault | Asalto a la carga
CLASS_RAVAGER_3 | Vicious Throw | Lanzamiento violento
  |   |  
CLASS_TRICKSTER_NAME | Trickster | Artero
CLASS_TRICKSTER_1 | Private Collection | Colección privada
CLASS_TRICKSTER_2 | Now You See Me | Ahora me ves
CLASS_TRICKSTER_3 | Arcane Fusion | Fusión Arcana
  |   |  
CLASS_AVENGER_NAME | Avenger | Vengador
CLASS_AVENGER_1 | Holy Champion | Campeón sagrado
CLASS_AVENGER_2 | Vengeful Smite | Aniquilación vengativa
CLASS_AVENGER_3 | Death From Above | Muerte desde arriba
  |   |  
CLASS_RAIDER_NAME | Raider | Incursor
CLASS_RAIDER_1 | Surprise Assault | Asalto por sorpresa
CLASS_RAIDER_2 | Divide the Spoils | Reparto de botín
CLASS_RAIDER_3 | Close the Gap | Acortar distancias
  |   |  
CLASS_LOREKEEPER_NAME | Lorekeeper | Guardián del Saber
CLASS_LOREKEEPER_1 | Ancient Remedy | Remedio antiguo
CLASS_LOREKEEPER_2 | Careful Balance | Equilibrio delicado
CLASS_LOREKEEPER_3 | All-Knowing | Omnisapiente
  |   |  
CLASS_TRUTHSEER_NAME | Truthseer | Augur de la Verdad
CLASS_TRUTHSEER_1 | True Sight | Visión verdadera
CLASS_TRUTHSEER_2 | Translocation | Translocación
CLASS_TRUTHSEER_3 | Precognition | Premonición

[mayjak]

The implementation of new translation string parser in #1135 fixes the "" issue and now it's properly grabbed from the english locale instead. I still need to implement a system to replace the missing texts that should be provided by the FFG app with Valkyrie-provided Spanish texts.
That's coming in the version after 2.5.2 release.

[mayjak]

[vidimus]

Thanks for your dedication, @mayjak

At least now they appear in English and they could be selected. Better than nothing.