Describe the bug
A clear and concise description of what the bug is.
validator 13.5.1 doesn't support 163/126 format email such as [email protected] or [email protected]
163/126 is Netease email service。It is very popular in China
validator 13.1.1 can support 163/126
Examples
If applicable, add screenshots to help explain your problem.
code: validator_mail.js
'use strict';
const validator = require('validator');
console.log(validator.isEmail(process.argv[2]));
13.5.1 test case:
npm install [email protected]
node validator_mail.js [email protected]
false
13.1.1 test case:
npm install [email protected]
node validator_mail.js [email protected]
true
Additional context
Validator.js version: 13.5.1
Node.js version:v11.2.0
OS platform: [windows, linux, macOS, etc] linux Ubuntu 18.04.1 LTS
We're also seeing this issue-- emails where the domain name is just numbers are now considered invalid.
Here's the problem I think: https://github.com/validatorjs/validator.js/pull/1474/files#diff-3b6763f98d8f87da73f519e2f3e4c0adea82d001683f51e1c7beba87f6782b0eR37
@CristhianMotoche is not testing the TLD because it was poped on line 26 😅
@CristhianMotoche -- can look into this?
Hi! I'll try to take a look at it later today.
Cool, thanks!
I'm sorry, but I haven't had the time to check this. 😞
I hope to have some time to review it on the weekend.
No worries, it's alright.
Hi! I was checking the issues and PRs and I think I'm late to fix this. It seems PR #1546 will address this and some additional fixes for isFQDN.
Sorry @CristhianMotoche i didn't see this issue and that you were assigned to fix it 😅
No worries. Actually, thanks for solving it. :smile:
Fixed in #1546 -- will release this patch as a hotfix due to the regression.