Validator.js: Hacktoberfest is here!!!

[ezkemboi]

@profnandaa and @tux-tn, any plans to add the project as part of the Hacktoberfest Challenge?

[tux-tn]

Looks like many Open Source projects are struggling with spam PRs because of Hacktoberfest :sweat_smile:

[ezkemboi]

I have also got that comment from many people.
We experienced some spam PR's last here.
People opened PR and issues that were not helpful or outside the project scope.
Since there has been that complaint, we might need to ignore it on the project.
Maybe we hear from other people.
Cc. @rubiin

[profnandaa]

I’m all for it, if this becomes entry to opensource for folks. We can deal
with the “collateral damage” :)

./na

On Sat, Oct 3, 2020 at 3:54 PM Ezrqn Kemboi [e-mail]
wrote:

>
>

I have also got that comment from many people.

We experienced some spam PR's last here.

People opened PR and issues that were not helpful or outside the project
scope.

Since there has been that complaint, we might need to ignore it on the
project.

Maybe we hear from other people.

Cc. @rubiin https://github.com/rubiin

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/validatorjs/validator.js/issues/1452#issuecomment-703099187,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB7ZEJCJTAJAJSXQ7LJNP3SI4NI7ANCNFSM4SBJKKHQ
.

--
Sent from a tiny device while on the move.

[rubiin]

@profnandaa i have sent some prs , check them out. the rest are on the way

[profnandaa]

Sure, will be on them.

./na

On Sat, Oct 3, 2020 at 4:14 PM Rubin Bhandari [e-mail]
wrote:

>
>

@profnandaa https://github.com/profnandaa i have sent some prs , check
them out. the rest are on the way

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/validatorjs/validator.js/issues/1452#issuecomment-703101888,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAB7ZELNT3MRFFRCPXPVORTSI4PTZANCNFSM4SBJKKHQ
.

--
Sent from a tiny device while on the move.

[rubiin]

To get more hands on deck, I think the repo should opt in to hacktoberfest to get most out of the event.
https://hacktoberfest.digitalocean.com/hacktoberfest-update @profnandaa
TLDR, you just need to add hacktoberfest topic to the repo and apply a label of hacktoberfest-accepted on merged pr and that would be all

[profnandaa]

I have added the topic to the repo, I think we're good now. Looks like there's no need to add the label on each PR:

PRs count if:
Submitted in a repo with the hacktoberfest topic AND
during the month of October AND (
The PR is merged OR
The PR is labelled as hacktoberfest-accepted by a maintainer OR
The PR has been approved
)