Validator.js: Feature Request: Currency: Option to Require Thousands Separator

Created on 16 Oct 2018  路  5Comments  路  Source: validatorjs/validator.js

We're using this to help validate data that includes currency. We want to make sure that a comma separator is always present.

good first issue hacktoberfest help wanted pr-raised 馃檵鈥嶁檪锔廸eature-request
Source
picture OlllllllO

All 5 comments

There's an pull request open to resolve that issue: #945

Maxim-Mazurok picture Maxim-Mazurok on 30 Nov 2018

Thanks @Maxim-Mazurok, will review and get back 馃憤

profnandaa picture profnandaa on 7 Dec 2018

@profnandaa - hello. any update on when this feature will get merged in? thanks.

OlllllllO picture OlllllllO on 4 Dec 2020

IDK why this PR wasn't merged: https://github.com/validatorjs/validator.js/pull/1084
It looks like a totally valid approach to me. There's no such thing as too many options, especially when people asked for this option... IMO

Maxim-Mazurok picture Maxim-Mazurok on 5 Dec 2020
👍1

1084 was closed without getting merged and it seems that this feature just got lost in the mix. Any chance of revisiting?

OlllllllO picture OlllllllO on 10 Dec 2020
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

woverton picture woverton  路  4Comments
mren picture mren  路  3Comments
malkhuzayyim picture malkhuzayyim  路  4Comments
MindRapist picture MindRapist  路  4Comments
RPDeshaies picture RPDeshaies  路  4Comments