Validator.js: Credit card: Maestro

[sazarkin]

It would be nice to include in your regexp this maestro cards:

6759649826438453
6799990100000000019

thanx!

[denjaland]

Maestro isn't a credit card, but a debet card.
I would prefer second method isDebetCard() and optionally a validator isPayCard() or somthing which would allow for both credit or debet cards in the validation.

Please do not include maestro in credit card by default though; that way the name of the method does not longer reflect the actual validation. Thanks very much!

[sazarkin]

Technically you correct, but you cannot judge credit/debit only by card number. A lot of visa/master cards are debit and valid according to this validator.

[denjaland]

Fair enough. I would prefer another validator name in that case though.

[roydondsouza]

Do we use Luhn Algorithm to validate credit card numbers within this library or something else?

[roydondsouza]

@denjaland as far as I know only an issuing bank can tell you if a card is debit or credit, you cannot determine type just from the numbers; that being said, binlist lookup - identifies some card types for US and Canada;

[denjaland]

@roydondsouza you are right, which is why I still would prefer a method "isPayCard" ;-)
a method "iscreditcard" does not do what it promises :-)

[profnandaa]

Anyone still needs this?

[usebaz]

@profnandaa yes I would like it to be added

[felipebraga]

Some Brazilians credit card have the same issue.

Elo and some MasterCard like 5031 4332 1540 6351

[dmarreco]

+1 on Elo and some MasterCard. Same issue here.

[ezkemboi]

I will take a look at this and probably raise a PR for the same.
Cc. @profnandaa.

[parasg1999]

@profnandaa Support for 19 digit card numbers was added in #1161. This was the main issue here. So it may be closed OR if we need to rename the isCreditCard method to isPayCard, I'd be happy to make a PR :)

[profnandaa]

Sure we can close this one, no need to rename. Thanks for spotting.