V8-archive: Add new fields to / endpoint

Created on 30 Sep 2019  ·  5Comments  ·  Source: directus/v8-archive

Feature Request

For the new login page, we'd like to have additional fields for images we can use. Currently we have project_name and project_logo. We should add project_icon, project_color, and project_image.

image

enhancement

Most helpful comment

Fixed in #1389

Hi,

unfortunately the fix don't work on the new installation, because the seeder already creates entries for project_foreground and project_background in the directus_settings table, so the renaming of the old fields in the schema upgrade results in the constraint violation exception.

I've fixed this in the https://github.com/directus/api/pull/1391, please check it.

Thanks ans best regards

All 5 comments

Hey @bjgajjar — I just saw that you are "renaming" the logo to project_logo on the / endpoint, but we want to write migrations to rename the actual field. That way this is set to project_logo in the database too (and the label on the App Settings). Can we make that change?

Also, the project_icon is actually supposed to be an image (file), not a string/icon. But this confusion made me realize we need clearer naming... so let's do this:

project_name = All set
app_url = Remove this
project_color = All set
logo = Rename to project_logo
project_icon = Rename to project_foreground and convert to a file type
project_image = Rename to project_background

Fixed in #1389

Hi,

unfortunately the fix don't work on the new installation, because the seeder already creates entries for project_foreground and project_background in the directus_settings table, so the renaming of the old fields in the schema upgrade results in the constraint violation exception.

I've fixed this in the https://github.com/directus/api/pull/1391, please check it.

Thanks ans best regards

Hey @arboehme - Thanks for reporting the issue as well as send the PR ❤️

It was a known issue and we already put that in our queue. But thank you so much for making it easy for us with sending PR. We appreciate it.

I'll review it ASAP :)

Was this page helpful?
0 / 5 - 0 ratings