V: Incorrect line numbers for files with \r\n

Created on 5 May 2020 · 7Comments · Source: vlang/v

V version: 0.1.26 9e715b8
OS: Windows

What did you do?

Create a new project.
Create test.v and write the code below.
Run v test.v or v run test.v

test.v

// Comment line 1
// Comment line 2
fn func1() {
    println('Inside func 1')
}

fn main() {
    func1()
    a = 2
    println('a is $a')
}

What did you expect to see?

Syntax error on lines 9 and 10. And an error message similar to:

test.v:9:5: error: undefined: `a`
    7 | fn main() {
    8 |     func1()
    9 |     a = 2
      |     ^
   10 |     println('a is $a')
   11 | }
test.v:10:20: error: undefined: `a`
    8 |     func1()
    9 |     a = 2
   10 |     println('a is $a')
      |                    ^
   11 | }

What did you see instead?

Syntax error reason is correct but on the wrong line numbers. 7 instead of 9 and 8 instead of 10.

.\test.v:7:2: error: undefined: `a`
    5 | }
    6 |
    7 | fn main() {
      |  ^
    8 |     func1()
    9 |     a = 2
.\test.v:8:17: error: undefined: `a`
    6 |
    7 | fn main() {
    8 |     func1()
      |
    9 |     a = 2
   10 |     println('a is $a')

Bug Confirmed

Source

hungrybluedev

Most helpful comment

Fixed in 47f59d3

spytheman on 26 Aug 2020

❤5

All 7 comments

Win10 1909
V 0.1.26 24aff9e.67a50b5

D:\test\v\tt1>v run .
.\tt1.v:9:2: error: undefined: `a` 
    7 | fn main() {
    8 |     func1()
    9 |     a = 2
      |     ^
   10 |     println('a is $a')
   11 | }
.\tt1.v:10:17: error: undefined: `a` 
    8 |     func1()
    9 |     a = 2
   10 |     println('a is $a')
      |                    ^
   11 | }

No problems.