Uvloop: Server fails to shutdown while persistent connections exist

[ciscorn]

I noticed that my aiohttp server with uvloop==0.11.0 awaits until all connections (WebSocket, streaming, etc.) are closed. This behavior prevents us from performing aiohttp's graceful shutdown.

This problem doesn't occur with uvloop==0.10.2.

I'm suspecting the commit 124e981bc90fbe2814dd1efd051e5b5a394cf1df because this change seems not to conform to the following spec:

asyncio.Server.close()
Stop serving: close listening sockets and set the sockets attribute to None.
The sockets that represent existing incoming client connections are left open.

[1st1]

Can you submit a PR to revert that commit and maybe write a unittest?

[ciscorn]

I wrote a test and then reverted the 124e981bc90fbe2814dd1efd051e5b5a394cf1df, but the test still fails with uvloop.
I'll investigate further and write a PR.

[1st1]

Thanks!

[ciscorn]

Sorry, I didn’t remove the generated .c file.

After running python3 setup.py bulid_ext --cython-always, the reverted revision passed the test.

[pvizeli]

Can we have a bugfix release?

[1st1]

Fixed in uvloop 0.11.1. Thanks for working on this!