Urllib3: Error decoding chunked response in _update_chunk_length

[KonMann]

Error decoding chunked response in _update_chunk_length: ValueError: invalid literal for int() with base 16: b'HTTP/1.1 200 OK\r\n'
Originally a Requests-Issue
Does the suggested fix, to check for the length, sound okay to you?
If so, I could just create a PR.

[sethmlarson]

With proper unit tests I'd accept a PR with those changes.

[KonMann]

Actually on second thought, I think it is legit to throw an exception in this situation

[hixss]

We temporarily repaired it in this way. I wonder if there will be any problem.

def _update_chunk_length(self):
    # First, we'll figure out length of a chunk and then
    # we'll try to read it from socket.
    if self.chunk_left is not None:
        return
    line = self._fp.fp.readline()
    line = line.split(b';', 1)[0]
    try:
        if len(line) == 0:
            self.chunk_left = 0
        else:
            self.chunk_left = int(line, 16)
    except ValueError:
        # Invalid chunked protocol response, abort.
        self.close()
        raise httplib.IncompleteRead(line)

[KonMann]

I just thought it was fine to throw that exception when the connection was just closed and not data is left available. So this would need to be dealt with on a higher level (In this case requests).

[ddugovic]

Can a more meaningful exception/error be raised than Error decoding chunked response in _update_chunk_length: ValueError: invalid literal for int() with base 16: b'HTTP/1.1 200 OK\r\n' - something which doesn't indicate a urllib3 bug?

[sethmlarson]

So is this issue a bug or not? If it's a bug instead of changing the error message I'd rather fix the issue.

Are there any public facing websites that always trigger this issue or do you have an example chunked body that causes it?

[ShailChoksi]

We use this on Lichess (https://lichess.org/) and all Lichess Bots go down due to this: https://github.com/careless25/lichess-bot/issues/163