Urllib3: AppEngineManager should provide an _original_response object.

Created on 30 May 2017  Â·  8Comments  Â·  Source: urllib3/urllib3

See the rationale on kennethreitz/requests#4044.

Help Wanted

All 8 comments

Did someone take care of this issue above (https://github.com/requests/requests/issues/4039)? It's still present in requests library due to a missing attribute in urllib3 through GAE.

@cmin764 this issue is still open because this hasn't been fixed.

I just haven't had time to take this on as some other projects have been encroaching on my OSS time. If someone else wants to grab it before I can get to it, go ahead - I'll be happy to review the PR. :)

Is there anything new with that?
I'm an AppEngine standard environment user which uses requests over multiple projects and for now 'all' I have is this patch: https://github.com/requests/requests/pull/4044/files being copied to my lib directories every time, and when I don't do that my code fails due to the cookies issue :(
I'm looking for a more stable solution, is this fix anywhere soon on your project planning?
Thanks! :)

It is still on hold and should be solved by urllib3 I guess. Anyway, a
more stable way to do that is to make a live monkey patch into the
appengine_config.py file as in the following files:

1.
https://raw.githubusercontent.com/Skillin/skillin/master/appengine_config.py?token=AArRvV2IGFG9uD6x9W471_x9Owhx_psKks5Z3N8ywA%3D%3D
2.
https://raw.githubusercontent.com/Skillin/skillin/master/skillin/patches.py?token=AArRvXhEq6F4C1CyivmQBmjvtRUlzTFVks5Z3N-UwA%3D%3D

skillin is a package name and contains the patches.py file, but move
things around as you want.

On Oct 3, 2017 4:14 PM, "rotemvilsa" notifications@github.com wrote:

Is there anything new with that?
I'm an AppEngine standard environment user which uses requests over
multiple projects and for now 'all' I have is this patch:
https://github.com/requests/requests/pull/4044/files being copied to my
lib directories every time, and when I don't do that my code fails due to
the cookies issue :(
I'm looking for a more stable solution, is this fix anywhere soon on your
project planning?
Thanks! :)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/shazow/urllib3/issues/1193#issuecomment-333837535,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AArRvcyWAzC8YPLph6u33ivbT3msYJvnks5sojM1gaJpZM4NqlrD
.

I just added #1283 which suppose to handle this.

Running into this issue with current gCloud appengine SDK...

Closed in #1283

Was this page helpful?
0 / 5 - 0 ratings

Related issues

pquentin picture pquentin  Â·  6Comments

glaukon-ariston picture glaukon-ariston  Â·  5Comments

markstory picture markstory  Â·  5Comments

sigmavirus24 picture sigmavirus24  Â·  7Comments

bgrant picture bgrant  Â·  3Comments