Setup: GDrive + Companion (on Heroku) with Redis + React Dashboard + S3 Multipart
Steps to Reproduce:
0 Login to google drive
1 Select picture (or any other file) from google drive
2 Click upload
3 On complete-event check uploadURL is defined
Expected:
uploadURL points to the S3 Url the file is located at
Actual:
uploadURL is null
In the entire result handed to the on-success handler the S3 url nowhere to be spotted
Looking in the bucket, the file was uploaded to S3
Debugging the traffic to wss://
{"action":"success","payload":{"response":{"responseText":"{\"ETag\":\"\\"...\\"\",\"VersionId\":\"...\",\"Location\":\"https://
My debugging efforts:
I believe the url should not be null here:
https://github.com/transloadit/uppy/blob/master/packages/%40uppy/companion/src/server/Uploader.js#L483 , but instead parsed out of data (as in responseText: JSON.stringify(data))
Other notes: Uploading a local file to S3 works like a charm and returns the uploadURL correctly
Tried out above proposition in https://github.com/transloadit/uppy/pull/1608 on my server and it works.
Thanks for raising this issue and submitting a PR already as well! We looked at it with @goto-bus-stop and @arturi and it looks good, @ifedapoolarewaju if you can give it your seal of approval, you can merge the PR and this issue will be closed :)
Thank you again @Zyclotrop-j!
Most helpful comment
Thanks for raising this issue and submitting a PR already as well! We looked at it with @goto-bus-stop and @arturi and it looks good, @ifedapoolarewaju if you can give it your seal of approval, you can merge the PR and this issue will be closed :)
Thank you again @Zyclotrop-j!