All 16 comments
Could @kiloreux and @ifedapoolarewaju please help with this issue? 🙏
arturi
on 18 Feb 2019
@arturi Added to my todos for this week.
kiloreux
on 18 Feb 2019
@ifedapoolarewaju do you think we can read secrets from a file. I have setup secrets mounting on our k8s cluster and docker but companion still needs to read those from a file.
kiloreux
on 4 Mar 2019
That would be the approach postgres for example takes.
dargmuesli
on 4 Mar 2019
Just a friendly note that Ife is on holidays and will be back after March 11
kvz
on 4 Mar 2019
@ifedapoolarewaju friendly reminder after the holidays ;)
arturi
on 19 Mar 2019
Hey,
We run companion mainly on a kubernetes cluster that offers Secrets resources. Docker secrets is an exclusive swarm feature for now and for docker-compose you can still use env variables. So we don't feel like this is something that we need to prioritize now.
kiloreux
on 28 Mar 2019
Umm... what's the difference? Both can be read from a file, can't they?
dargmuesli
on 29 Mar 2019
That's true. But defining the resource as a file requires it to be loaded as a volume in the first place and we are taking a different approach now here. Now this is not to say that we will not implement this, but not a priority currently.
kiloreux
on 29 Mar 2019
Hi there, I think we are good here so I'll be closing this issue now, but if I am mistaken, please do re-open!
kvz
on 29 May 2019
Now this is not to say that we will not implement this, but not a priority currently.
The implementation was just delayed, not canceled or completed afaik. Please reopen, I can't do that.
dargmuesli
on 29 May 2019
Ah, I see now. Since we are using K8 secrets now, we regarded the immediate issue to be resolved. I am afraid that Docker is not a primary target platform for us so it would be costly to have our engineers build this for you. We're open to PRs for this though, is that something you'd consider?
kvz
on 29 May 2019
Yes, I'd consider a PR. The project I personally require Uppy for is currently on hold though, but I've studied myself for quite sometime now and observed that I can't see open issues without feeling the need to close them. So I'm sure I'll find myself coding this at the goulash programming night(s). Either way this is a great project that I'd be happy to support with a little PR :)
dargmuesli
on 29 May 2019
Hey that looks really good! And they have Mate :heart_eyes: that'll get the job done for sure haha. Let us know if you run into anything, happy to answer questions!
kvz
on 29 May 2019
Do let us know if you need a hand and we'll re-open. I'm closing this in the meantime to keep our open issue count somewhat modest :ok_hand:
kvz
on 3 Jun 2019
Sure, I still have this on my todo list! The GPN had such a great athmosphere tough, I was basically left mentally paralysed by the combination of music and visuals and thus I was very unproductive – at least in regards to PRs. Allow me a few hours to think about the significance of "programming" in GPN and after that I'll have a look into this one 😊
dargmuesli
on 3 Jun 2019
Related issues
ghost
·
4Comments
agreene-coursera
·
4Comments
oyeanuj
·
3Comments
yaegor
·
3Comments
hikurangi
·
4Comments
Most helpful comment
Sure, I still have this on my todo list! The GPN had such a great athmosphere tough, I was basically left mentally paralysed by the combination of music and visuals and thus I was very unproductive – at least in regards to PRs. Allow me a few hours to think about the significance of "programming" in GPN and after that I'll have a look into this one 😊